Re: [PATCH v4 3/7] ccid: build smartcard as module

2020-06-30 Thread Daniel P . Berrangé
On Tue, Jun 30, 2020 at 06:07:51PM +0200, Gerd Hoffmann wrote: > > >> static const TypeInfo qcrypto_tls_creds_x509_info = { > > >> .parent = TYPE_QCRYPTO_TLS_CREDS, > > >> .name = TYPE_QCRYPTO_TLS_CREDS_X509, > > >> .module_name = "gnu-tls", > > >> ... > > >> } > > > >

Re: [PATCH v4 3/7] ccid: build smartcard as module

2020-06-30 Thread Gerd Hoffmann
> >> static const TypeInfo qcrypto_tls_creds_x509_info = { > >> .parent = TYPE_QCRYPTO_TLS_CREDS, > >> .name = TYPE_QCRYPTO_TLS_CREDS_X509, > >> .module_name = "gnu-tls", > >> ... > >> } > > > > Not as-is. You'll need module load hooks in more places then and some > >

Re: [PATCH v4 3/7] ccid: build smartcard as module

2020-06-30 Thread Philippe Mathieu-Daudé
On 6/23/20 7:12 PM, Gerd Hoffmann wrote: > Hi, > >>> +{ .type = "ccid-card-passthru",.mod = "usb-smartcard" }, >>> +{ .type = "ccid-card-emulated",.mod = "usb-smartcard" }, >> >> We want to use type definitions here (such TYPE_CCID_PASSTHRU), >> as we don't guaran

Re: [PATCH v4 3/7] ccid: build smartcard as module

2020-06-23 Thread Gerd Hoffmann
Hi, > > +{ .type = "ccid-card-passthru",.mod = "usb-smartcard" }, > > +{ .type = "ccid-card-emulated",.mod = "usb-smartcard" }, > > We want to use type definitions here (such TYPE_CCID_PASSTHRU), > as we don't guaranty them stable. Hmm? I'm pretty sure '-device

Re: [PATCH v4 3/7] ccid: build smartcard as module

2020-06-23 Thread Philippe Mathieu-Daudé
Hi Gerd, On 6/22/20 3:55 PM, Gerd Hoffmann wrote: > Drops libcacard.so dependency from core qemu. > > Signed-off-by: Gerd Hoffmann > --- > Makefile.objs| 1 + > hw/core/qdev.c | 2 ++ > hw/Makefile.objs | 1 + > hw/usb/Makefile.objs | 4 +++- > 4 files changed, 7 insertions(+)

[PATCH v4 3/7] ccid: build smartcard as module

2020-06-22 Thread Gerd Hoffmann
Drops libcacard.so dependency from core qemu. Signed-off-by: Gerd Hoffmann --- Makefile.objs| 1 + hw/core/qdev.c | 2 ++ hw/Makefile.objs | 1 + hw/usb/Makefile.objs | 4 +++- 4 files changed, 7 insertions(+), 1 deletion(-) diff --git a/Makefile.objs b/Makefile.objs index 7ce