Re: [PATCH v5 00/13] hw/block/nvme: metadata and end-to-end data protection support

[Klaus Jensen]

On Mar 10 10:53, Klaus Jensen wrote:
> From: Klaus Jensen 
> 
> This is v5 of a series that adds support for metadata and end-to-end
> data protection.
> 
> First, on the subject of metadata, in v1, support was restricted to
> extended logical blocks, which was pretty trivial to implement, but
> required special initialization and broke DULBE. In v2, metadata is
> always stored continuously at the end of the underlying block device.
> This has the advantage of not breaking DULBE since the data blocks
> remains aligned and allows bdrv_block_status to be used to determinate
> allocation status. It comes at the expense of complicating the extended
> LBA emulation, but on the other hand it also gains support for metadata
> transfered as a separate buffer.
> 
> The end-to-end data protection support blew up in terms of required
> changes. This is due to the fact that a bunch of new commands has been
> added to the device since v1 (zone append, compare, copy), and they all
> require various special handling for protection information. If
> potential reviewers would like it split up into multiple patches, each
> adding pi support to one command, shout out.
> 
> Support for metadata and end-to-end data protection is all joint work
> with Gollu Appalanaidu.
> 
> v5:
>   * add a required fix for zone management receive when metadata is
> involved
>   * add a couple of refactor patches for the zoned init code to make the
> format nvm patch more straight forward wrt. formatting of zoned
> namespaces.
> 

FYI, the SPDK e2edp test (tests/nvme/e2edp/nvme_dp) fails on this series
when metadata is more than 8 bytes. This is a bug in the test and I've
posted a fix upstream for this.

  https://review.spdk.io/gerrit/c/spdk/spdk/+/6891


--
k


signature.asc
Description: PGP signature

[PATCH v5 00/13] hw/block/nvme: metadata and end-to-end data protection support

[Klaus Jensen]

From: Klaus Jensen 

This is v5 of a series that adds support for metadata and end-to-end
data protection.

First, on the subject of metadata, in v1, support was restricted to
extended logical blocks, which was pretty trivial to implement, but
required special initialization and broke DULBE. In v2, metadata is
always stored continuously at the end of the underlying block device.
This has the advantage of not breaking DULBE since the data blocks
remains aligned and allows bdrv_block_status to be used to determinate
allocation status. It comes at the expense of complicating the extended
LBA emulation, but on the other hand it also gains support for metadata
transfered as a separate buffer.

The end-to-end data protection support blew up in terms of required
changes. This is due to the fact that a bunch of new commands has been
added to the device since v1 (zone append, compare, copy), and they all
require various special handling for protection information. If
potential reviewers would like it split up into multiple patches, each
adding pi support to one command, shout out.

Support for metadata and end-to-end data protection is all joint work
with Gollu Appalanaidu.

v5:
  * add a required fix for zone management receive when metadata is
involved
  * add a couple of refactor patches for the zoned init code to make the
format nvm patch more straight forward wrt. formatting of zoned
namespaces.

v4:
  * promoted from RFC
  * moved most eedp additions to nvme-dif.{c,h}. (Keith)

v3:

  * added patch with Verify command
  * added patches for multiple LBA formats and Format NVM
  * changed NvmeSG to be a union (Keith)

Gollu Appalanaidu (1):
  hw/block/nvme: add verify command

Klaus Jensen (10):
  hw/block/nvme: fix zone management receive reporting too many zones
  hw/block/nvme: add metadata support
  hw/block/nvme: end-to-end data protection
  hw/block/nvme: add non-mdts command size limit for verify
  hw/block/nvme: prefer runtime helpers instead of device parameters
  hw/block/nvme: pull lba format initialization
  hw/block/nvme: parameterize nvme_ns_nlbas
  hw/block/nvme: remove invalid zone resource checks
  hw/block/nvme: move zoned constraints checks
  hw/block/nvme: split zone check/set geometry

Minwoo Im (2):
  hw/block/nvme: support multiple lba formats
  hw/block/nvme: add support for the format nvm command

 hw/block/nvme-dif.h   |   53 ++
 hw/block/nvme-ns.h|   61 +-
 hw/block/nvme.h   |   34 ++
 include/block/nvme.h  |   29 +-
 hw/block/nvme-dif.c   |  508 +
 hw/block/nvme-ns.c|  259 ++---
 hw/block/nvme.c   | 1267 +
 hw/block/meson.build  |2 +-
 hw/block/trace-events |   22 +-
 9 files changed, 2018 insertions(+), 217 deletions(-)
 create mode 100644 hw/block/nvme-dif.h
 create mode 100644 hw/block/nvme-dif.c

-- 
2.30.1