Re: [PATCH v5 07/13] job: Do not soft-cancel after a job is done

2021-10-07 Thread Vladimir Sementsov-Ogievskiy
10/6/21 18:19, Hanna Reitz wrote: The only job that supports a soft cancel mode is the mirror job, and in such a case it resets its .cancelled field before it leaves its .run() function, so it does not really count as cancelled. However, it is possible to cancel the job after .run() returns and

Re: [PATCH v5 07/13] job: Do not soft-cancel after a job is done

2021-10-06 Thread Eric Blake
On Wed, Oct 06, 2021 at 05:19:34PM +0200, Hanna Reitz wrote: > The only job that supports a soft cancel mode is the mirror job, and in > such a case it resets its .cancelled field before it leaves its .run() > function, so it does not really count as cancelled. > > However, it is possible to

[PATCH v5 07/13] job: Do not soft-cancel after a job is done

2021-10-06 Thread Hanna Reitz
The only job that supports a soft cancel mode is the mirror job, and in such a case it resets its .cancelled field before it leaves its .run() function, so it does not really count as cancelled. However, it is possible to cancel the job after .run() returns and before job_exit() (which is run in