Re: [PATCH v5 1/1] virtio-net: Add check for mac address while peer is vdpa

2021-03-01 Thread Sean Mooney
On Thu, 2021-02-25 at 14:14 -0500, Michael S. Tsirkin wrote: > On Fri, Feb 26, 2021 at 12:55:06AM +0800, Cindy Lu wrote: > > While peer is vdpa, sometime qemu get an all zero mac address from the > > hardware, > > This is not a legal value. Add the check for this.if we get an zero mac > >

Re: [PATCH v5 1/1] virtio-net: Add check for mac address while peer is vdpa

2021-02-28 Thread Adrian Moreno
On 3/1/21 2:36 AM, Cindy Lu wrote: > On Mon, Mar 1, 2021 at 4:40 AM Michael S. Tsirkin wrote: >> >> On Thu, Feb 25, 2021 at 02:14:39PM -0500, Michael S. Tsirkin wrote: >>> On Fri, Feb 26, 2021 at 12:55:06AM +0800, Cindy Lu wrote: While peer is vdpa, sometime qemu get an all zero mac

Re: [PATCH v5 1/1] virtio-net: Add check for mac address while peer is vdpa

2021-02-28 Thread Cindy Lu
On Mon, Mar 1, 2021 at 4:40 AM Michael S. Tsirkin wrote: > > On Thu, Feb 25, 2021 at 02:14:39PM -0500, Michael S. Tsirkin wrote: > > On Fri, Feb 26, 2021 at 12:55:06AM +0800, Cindy Lu wrote: > > > While peer is vdpa, sometime qemu get an all zero mac address from the > > > hardware, > > > This

Re: [PATCH v5 1/1] virtio-net: Add check for mac address while peer is vdpa

2021-02-28 Thread Michael S. Tsirkin
On Thu, Feb 25, 2021 at 02:14:39PM -0500, Michael S. Tsirkin wrote: > On Fri, Feb 26, 2021 at 12:55:06AM +0800, Cindy Lu wrote: > > While peer is vdpa, sometime qemu get an all zero mac address from the > > hardware, > > This is not a legal value. Add the check for this.if we get an zero mac > >

Re: [PATCH v5 1/1] virtio-net: Add check for mac address while peer is vdpa

2021-02-25 Thread Michael S. Tsirkin
On Fri, Feb 26, 2021 at 12:55:06AM +0800, Cindy Lu wrote: > While peer is vdpa, sometime qemu get an all zero mac address from the > hardware, > This is not a legal value. Add the check for this.if we get an zero mac > address. > qemu will use the default mac address or the mac address from qemu

[PATCH v5 1/1] virtio-net: Add check for mac address while peer is vdpa

2021-02-25 Thread Cindy Lu
While peer is vdpa, sometime qemu get an all zero mac address from the hardware, This is not a legal value. Add the check for this.if we get an zero mac address. qemu will use the default mac address or the mac address from qemu cmdline Signed-off-by: Cindy Lu --- hw/net/virtio-net.c | 10