On 10/7/20 9:00 AM, Markus Armbruster wrote:
More abuse of review to learn: even through we initialize with False, we
still need the type hint?
Dunno.
jsnow@scv ~/s/q/scripts (python-qapi-cleanup-pt1)> mypy
--config-file=qapi/mypy.ini qapi/;
qapi/visit.py:40: error: Function is missing a
John Snow writes:
> Annotations do not change runtime behavior.
> This commit *only* adds annotations.
>
> Signed-off-by: John Snow
> Reviewed-by: Eduardo Habkost
> Reviewed-by: Cleber Rosa
> Tested-by: Cleber Rosa
> ---
> scripts/qapi/mypy.ini | 5 ---
> scripts/qapi/visit.py | 73
Annotations do not change runtime behavior.
This commit *only* adds annotations.
Signed-off-by: John Snow
Reviewed-by: Eduardo Habkost
Reviewed-by: Cleber Rosa
Tested-by: Cleber Rosa
---
scripts/qapi/mypy.ini | 5 ---
scripts/qapi/visit.py | 73 +--
2
