Re: [PATCH v5 6/6] multifd: Implement zerocopy write in multifd migration (multifd-zerocopy)

2021-12-09 Thread Leonardo Bras Soares Passos
On Thu, Dec 9, 2021 at 5:51 AM Leonardo Bras Soares Passos wrote: > > Hello Juan, > > On Tue, Nov 16, 2021 at 1:08 PM Juan Quintela wrote: > > > > Leonardo Bras wrote: > > > Implement zerocopy on nocomp_send_write(), by making use of QIOChannel > > > zerocopy interface. > > > > > > Change

Re: [PATCH v5 6/6] multifd: Implement zerocopy write in multifd migration (multifd-zerocopy)

2021-12-09 Thread Leonardo Bras Soares Passos
Hello Juan, On Tue, Nov 16, 2021 at 1:08 PM Juan Quintela wrote: > > Leonardo Bras wrote: > > Implement zerocopy on nocomp_send_write(), by making use of QIOChannel > > zerocopy interface. > > > > Change multifd_send_sync_main() so it can distinguish each iteration sync > > from > > the setup

Re: [PATCH v5 6/6] multifd: Implement zerocopy write in multifd migration (multifd-zerocopy)

2021-12-02 Thread Juan Quintela
Leonardo Bras Soares Passos wrote: > On Tue, Nov 16, 2021 at 1:08 PM Juan Quintela wrote: >> >> I would prefer to check for QIO_CHANNEL_FEATUR_WRITE_ZEROCPY there, but >> I can't see a way of doing that without a qio. > > Yeah, I think I should leave the feature testing in here, and move the >

Re: [PATCH v5 6/6] multifd: Implement zerocopy write in multifd migration (multifd-zerocopy)

2021-12-01 Thread Leonardo Bras Soares Passos
On Tue, Nov 16, 2021 at 1:40 PM Daniel P. Berrangé wrote: > > On Tue, Nov 16, 2021 at 05:34:50PM +0100, Juan Quintela wrote: > > Daniel P. Berrangé wrote: > > > > >> > > >> if (params->zerocopy && > > >> (params->parameters.multifd_compression != > > >> MULTIFD_COMPRESSION_NONE || >

Re: [PATCH v5 6/6] multifd: Implement zerocopy write in multifd migration (multifd-zerocopy)

2021-12-01 Thread Leonardo Bras Soares Passos
On Tue, Nov 16, 2021 at 1:35 PM Daniel P. Berrangé wrote: > > On Tue, Nov 16, 2021 at 04:17:47PM +, Daniel P. Berrangé wrote: > > On Tue, Nov 16, 2021 at 05:08:06PM +0100, Juan Quintela wrote: > > > Leonardo Bras wrote: > > > > Implement zerocopy on nocomp_send_write(), by making use of

Re: [PATCH v5 6/6] multifd: Implement zerocopy write in multifd migration (multifd-zerocopy)

2021-12-01 Thread Leonardo Bras Soares Passos
On Tue, Nov 16, 2021 at 1:08 PM Juan Quintela wrote: > > Leonardo Bras wrote: > > Implement zerocopy on nocomp_send_write(), by making use of QIOChannel > > zerocopy interface. > > > > Change multifd_send_sync_main() so it can distinguish each iteration sync > > from > > the setup and the

Re: [PATCH v5 6/6] multifd: Implement zerocopy write in multifd migration (multifd-zerocopy)

2021-11-16 Thread Daniel P . Berrangé
On Tue, Nov 16, 2021 at 05:34:50PM +0100, Juan Quintela wrote: > Daniel P. Berrangé wrote: > > >> > >> if (params->zerocopy && > >> (params->parameters.multifd_compression != > >> MULTIFD_COMPRESSION_NONE || > >> migrate_use_tls())) { > >>error_setg(, > >>

Re: [PATCH v5 6/6] multifd: Implement zerocopy write in multifd migration (multifd-zerocopy)

2021-11-16 Thread Juan Quintela
Daniel P. Berrangé wrote: >> >> if (params->zerocopy && >> (params->parameters.multifd_compression != MULTIFD_COMPRESSION_NONE >> || >> migrate_use_tls())) { >>error_setg(, >> "Zerocopy only available for non-compressed non-TLS >> multifd

Re: [PATCH v5 6/6] multifd: Implement zerocopy write in multifd migration (multifd-zerocopy)

2021-11-16 Thread Daniel P . Berrangé
On Tue, Nov 16, 2021 at 04:17:47PM +, Daniel P. Berrangé wrote: > On Tue, Nov 16, 2021 at 05:08:06PM +0100, Juan Quintela wrote: > > Leonardo Bras wrote: > > > Implement zerocopy on nocomp_send_write(), by making use of QIOChannel > > > zerocopy interface. > > > > > > Change

Re: [PATCH v5 6/6] multifd: Implement zerocopy write in multifd migration (multifd-zerocopy)

2021-11-16 Thread Daniel P . Berrangé
On Tue, Nov 16, 2021 at 05:08:06PM +0100, Juan Quintela wrote: > Leonardo Bras wrote: > > Implement zerocopy on nocomp_send_write(), by making use of QIOChannel > > zerocopy interface. > > > > Change multifd_send_sync_main() so it can distinguish each iteration sync > > from > > the setup and

Re: [PATCH v5 6/6] multifd: Implement zerocopy write in multifd migration (multifd-zerocopy)

2021-11-16 Thread Juan Quintela
Leonardo Bras wrote: > Implement zerocopy on nocomp_send_write(), by making use of QIOChannel > zerocopy interface. > > Change multifd_send_sync_main() so it can distinguish each iteration sync from > the setup and the completion, so a flush_zerocopy() can be called > at the after each iteration

[PATCH v5 6/6] multifd: Implement zerocopy write in multifd migration (multifd-zerocopy)

2021-11-11 Thread Leonardo Bras
Implement zerocopy on nocomp_send_write(), by making use of QIOChannel zerocopy interface. Change multifd_send_sync_main() so it can distinguish each iteration sync from the setup and the completion, so a flush_zerocopy() can be called at the after each iteration in order to make sure all dirty