Re: [PATCH v6 4/5] block/nbd: drop connection_co

2021-09-27 Thread Vladimir Sementsov-Ogievskiy
24.09.2021 20:44, Eric Blake wrote: On Thu, Sep 02, 2021 at 01:38:04PM +0300, Vladimir Sementsov-Ogievskiy wrote: OK, that's a big rewrite of the logic. And a time-consuming review on my part! Pre-patch we have an always running coroutine - connection_co. It does reply receiving and

Re: [PATCH v6 4/5] block/nbd: drop connection_co

2021-09-24 Thread Eric Blake
On Thu, Sep 02, 2021 at 01:38:04PM +0300, Vladimir Sementsov-Ogievskiy wrote: > OK, that's a big rewrite of the logic. And a time-consuming review on my part! > > Pre-patch we have an always running coroutine - connection_co. It does > reply receiving and reconnecting. And it leads to a lot of

[PATCH v6 4/5] block/nbd: drop connection_co

2021-09-02 Thread Vladimir Sementsov-Ogievskiy
OK, that's a big rewrite of the logic. Pre-patch we have an always running coroutine - connection_co. It does reply receiving and reconnecting. And it leads to a lot of difficult and unobvious code around drained sections and context switch. We also abuse bs->in_flight counter which is increased