Re: [PATCH v7 02/15] s390x: protvirt: Support unpack facility

2020-03-10 Thread Christian Borntraeger
On 09.03.20 15:40, Christian Borntraeger wrote: > something like the following? > > > diff --git a/target/s390x/cpu.c b/target/s390x/cpu.c > index c513f8efe0..cd12c29b9a 100644 > --- a/target/s390x/cpu.c > +++ b/target/s390x/cpu.c > @@ -185,13 +185,18 @@ static void

Re: [PATCH v7 02/15] s390x: protvirt: Support unpack facility

2020-03-09 Thread David Hildenbrand
>> >>> +CPUS390XState *env; >>> >>> /* get the reset parameters, reset them once done */ >>> s390_ipl_get_reset_request(, _type); >>> @@ -327,9 +411,16 @@ static void s390_machine_reset(MachineState *machine) >>> /* all CPUs are paused and synchronized at this point */ >>>

Re: [PATCH v7 02/15] s390x: protvirt: Support unpack facility

2020-03-09 Thread Janosch Frank
On 3/9/20 2:37 PM, David Hildenbrand wrote: > On 09.03.20 12:21, Janosch Frank wrote: >> The unpack facility provides the means to setup a protected guest. A >> protected guest can not be introspected by the hypervisor or any >> user/administrator of the machine it is running on. >> >> Protected

Re: [PATCH v7 02/15] s390x: protvirt: Support unpack facility

2020-03-09 Thread Janosch Frank
On 3/9/20 3:28 PM, Viktor Mihajlovski wrote: > > > On 3/9/20 12:21 PM, Janosch Frank wrote: >> The unpack facility provides the means to setup a protected guest. A >> protected guest can not be introspected by the hypervisor or any >> user/administrator of the machine it is running on. >> >>

Re: [PATCH v7 02/15] s390x: protvirt: Support unpack facility

2020-03-09 Thread David Hildenbrand
On 09.03.20 15:40, Christian Borntraeger wrote: > > > On 09.03.20 14:37, David Hildenbrand wrote: > >>> >>> +#if !defined(CONFIG_USER_ONLY) >>> +static bool machine_is_pv(MachineState *ms) >>> +{ >>> +Object *obj; >>> + >>> +/* we have to bail out for the "none" machine */ >>> +

Re: [PATCH v7 02/15] s390x: protvirt: Support unpack facility

2020-03-09 Thread Christian Borntraeger
On 09.03.20 14:37, David Hildenbrand wrote: >> >> +#if !defined(CONFIG_USER_ONLY) >> +static bool machine_is_pv(MachineState *ms) >> +{ >> +Object *obj; >> + >> +/* we have to bail out for the "none" machine */ >> +obj = object_dynamic_cast(OBJECT(ms), TYPE_S390_CCW_MACHINE); >>

Re: [PATCH v7 02/15] s390x: protvirt: Support unpack facility

2020-03-09 Thread Viktor Mihajlovski
On 3/9/20 12:21 PM, Janosch Frank wrote: The unpack facility provides the means to setup a protected guest. A protected guest can not be introspected by the hypervisor or any user/administrator of the machine it is running on. Protected guests are encrypted at rest and need a special boot

Re: [PATCH v7 02/15] s390x: protvirt: Support unpack facility

2020-03-09 Thread David Hildenbrand
On 09.03.20 12:21, Janosch Frank wrote: > The unpack facility provides the means to setup a protected guest. A > protected guest can not be introspected by the hypervisor or any > user/administrator of the machine it is running on. > > Protected guests are encrypted at rest and need a special

[PATCH v7 02/15] s390x: protvirt: Support unpack facility

2020-03-09 Thread Janosch Frank
The unpack facility provides the means to setup a protected guest. A protected guest can not be introspected by the hypervisor or any user/administrator of the machine it is running on. Protected guests are encrypted at rest and need a special boot mechanism via diag308 subcode 8 and 10. Code 8