Re: [PATCH v7 03/12] tests/vm: pass args through to BaseVM's __init__

2020-05-22 Thread Robert Foley
On Wed, 20 May 2020 at 17:49, Alex Bennée wrote: > > > Robert Foley writes: > > A brief rationale wouldn't go amiss in the commit message. e.g. "We will > shortly need to pass more parameters to the class so lets just pass args > rather than growing the parameter list." Good point. I will add

Re: [PATCH v7 03/12] tests/vm: pass args through to BaseVM's __init__

2020-05-20 Thread Alex Bennée
Robert Foley writes: A brief rationale wouldn't go amiss in the commit message. e.g. "We will shortly need to pass more parameters to the class so lets just pass args rather than growing the parameter list." Otherwise: Reviewed-by: Alex Bennée > Signed-off-by: Robert Foley > --- >

[PATCH v7 03/12] tests/vm: pass args through to BaseVM's __init__

2020-05-19 Thread Robert Foley
Signed-off-by: Robert Foley --- tests/vm/basevm.py | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/tests/vm/basevm.py b/tests/vm/basevm.py index a2d4054d72..fbefda0595 100644 --- a/tests/vm/basevm.py +++ b/tests/vm/basevm.py @@ -61,9 +61,9 @@ class