Re: [PATCH v7 12/40] accel/qtest: Implement AccelOpsClass::has_work()

2021-09-27 Thread Laurent Vivier
On 25/09/2021 18:01, Philippe Mathieu-Daudé wrote: On 9/25/21 17:32, Richard Henderson wrote: On 9/25/21 11:27 AM, Philippe Mathieu-Daudé wrote: +static bool qtest_cpu_has_work(CPUState *cpu) +{ +    g_assert_not_reached(); +} Sigh, this triggers: Running test qtest-i386/cpu-plug-test **

Re: [PATCH v7 12/40] accel/qtest: Implement AccelOpsClass::has_work()

2021-09-25 Thread Philippe Mathieu-Daudé
On 9/25/21 17:32, Richard Henderson wrote: On 9/25/21 11:27 AM, Philippe Mathieu-Daudé wrote: +static bool qtest_cpu_has_work(CPUState *cpu) +{ +    g_assert_not_reached(); +} Sigh, this triggers: Running test qtest-i386/cpu-plug-test ** ERROR:../accel/qtest/qtest.c:52:qtest_cpu_has_work:

Re: [PATCH v7 12/40] accel/qtest: Implement AccelOpsClass::has_work()

2021-09-25 Thread Richard Henderson
On 9/25/21 11:27 AM, Philippe Mathieu-Daudé wrote: +static bool qtest_cpu_has_work(CPUState *cpu) +{ +    g_assert_not_reached(); +} Sigh, this triggers: Running test qtest-i386/cpu-plug-test ** ERROR:../accel/qtest/qtest.c:52:qtest_cpu_has_work: code should not be reached ERROR

Re: [PATCH v7 12/40] accel/qtest: Implement AccelOpsClass::has_work()

2021-09-25 Thread Philippe Mathieu-Daudé
+Igor On 9/25/21 16:50, Philippe Mathieu-Daudé wrote: Implement QTest has_work() handler in AccelOpsClass. Since no CPU are available under QTest accelerator, this function is not reachable. Signed-off-by: Philippe Mathieu-Daudé --- accel/qtest/qtest.c | 6 ++ 1 file changed, 6

[PATCH v7 12/40] accel/qtest: Implement AccelOpsClass::has_work()

2021-09-25 Thread Philippe Mathieu-Daudé
Implement QTest has_work() handler in AccelOpsClass. Since no CPU are available under QTest accelerator, this function is not reachable. Signed-off-by: Philippe Mathieu-Daudé --- accel/qtest/qtest.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/accel/qtest/qtest.c