Re: [EXT] Re: [PATCH v7 3/5] virtio-iommu: Call iommu notifier for attach/detach

2020-03-18 Thread Jean-Philippe Brucker
arat Bhushan ; > >> linuc.dec...@gmail.com; eric.auger@gmail.com > >> Subject: [EXT] Re: [PATCH v7 3/5] virtio-iommu: Call iommu notifier for > >> attach/detach > >> > >> External Email > >> > >> -

Re: [EXT] Re: [PATCH v7 3/5] virtio-iommu: Call iommu notifier for attach/detach

2020-03-18 Thread Auger Eric
asz Nowicki [C] >> ; m...@redhat.com; drjo...@redhat.com; >> pet...@redhat.com; qemu-devel@nongnu.org; alex.william...@redhat.com; >> qemu-...@nongnu.org; Bharat Bhushan ; >> linuc.dec...@gmail.com; eric.auger@gmail.com >> Subject: [EXT] Re: [PATCH v7 3/5] vir

RE: [EXT] Re: [PATCH v7 3/5] virtio-iommu: Call iommu notifier for attach/detach

2020-03-18 Thread Bharat Bhushan
m; qemu-devel@nongnu.org; alex.william...@redhat.com; > qemu-...@nongnu.org; Bharat Bhushan ; > linuc.dec...@gmail.com; eric.auger@gmail.com > Subject: [EXT] Re: [PATCH v7 3/5] virtio-iommu: Call iommu notifier for &g

Re: [PATCH v7 3/5] virtio-iommu: Call iommu notifier for attach/detach

2020-03-18 Thread Jean-Philippe Brucker
On Wed, Mar 18, 2020 at 03:47:44PM +0530, Bharat Bhushan wrote: > Hi Jean, > > On Tue, Mar 17, 2020 at 9:29 PM Jean-Philippe Brucker > wrote: > > > > On Tue, Mar 17, 2020 at 02:46:55PM +0530, Bharat Bhushan wrote: > > > Hi Jean, > > > > > > On Tue, Mar 17, 2020 at 2:23 PM Jean-Philippe Brucker >

Re: [PATCH v7 3/5] virtio-iommu: Call iommu notifier for attach/detach

2020-03-18 Thread Bharat Bhushan
Hi Jean, On Tue, Mar 17, 2020 at 9:29 PM Jean-Philippe Brucker wrote: > > On Tue, Mar 17, 2020 at 02:46:55PM +0530, Bharat Bhushan wrote: > > Hi Jean, > > > > On Tue, Mar 17, 2020 at 2:23 PM Jean-Philippe Brucker > > wrote: > > > > > > On Tue, Mar 17, 2020 at 12:40:39PM +0530, Bharat Bhushan

Re: [PATCH v7 3/5] virtio-iommu: Call iommu notifier for attach/detach

2020-03-17 Thread Jean-Philippe Brucker
On Tue, Mar 17, 2020 at 02:46:55PM +0530, Bharat Bhushan wrote: > Hi Jean, > > On Tue, Mar 17, 2020 at 2:23 PM Jean-Philippe Brucker > wrote: > > > > On Tue, Mar 17, 2020 at 12:40:39PM +0530, Bharat Bhushan wrote: > > > Hi Jean, > > > > > > On Mon, Mar 16, 2020 at 3:41 PM Jean-Philippe Brucker >

Re: [PATCH v7 3/5] virtio-iommu: Call iommu notifier for attach/detach

2020-03-17 Thread Bharat Bhushan
Hi Jean, On Tue, Mar 17, 2020 at 2:23 PM Jean-Philippe Brucker wrote: > > On Tue, Mar 17, 2020 at 12:40:39PM +0530, Bharat Bhushan wrote: > > Hi Jean, > > > > On Mon, Mar 16, 2020 at 3:41 PM Jean-Philippe Brucker > > wrote: > > > > > > Hi Bharat, > > > > > > Could you Cc me on your next

Re: [PATCH v7 3/5] virtio-iommu: Call iommu notifier for attach/detach

2020-03-17 Thread Jean-Philippe Brucker
On Tue, Mar 17, 2020 at 12:40:39PM +0530, Bharat Bhushan wrote: > Hi Jean, > > On Mon, Mar 16, 2020 at 3:41 PM Jean-Philippe Brucker > wrote: > > > > Hi Bharat, > > > > Could you Cc me on your next posting? Unfortunately I don't have much > > hardware for testing this at the moment, but I might

Re: [PATCH v7 3/5] virtio-iommu: Call iommu notifier for attach/detach

2020-03-17 Thread Auger Eric
Hi Bharat, On 3/17/20 8:10 AM, Bharat Bhushan wrote: > Hi Jean, > > On Mon, Mar 16, 2020 at 3:41 PM Jean-Philippe Brucker > wrote: >> >> Hi Bharat, >> >> Could you Cc me on your next posting? Unfortunately I don't have much >> hardware for testing this at the moment, but I might be able to

Re: [PATCH v7 3/5] virtio-iommu: Call iommu notifier for attach/detach

2020-03-17 Thread Bharat Bhushan
Hi Jean, On Mon, Mar 16, 2020 at 3:41 PM Jean-Philippe Brucker wrote: > > Hi Bharat, > > Could you Cc me on your next posting? Unfortunately I don't have much > hardware for testing this at the moment, but I might be able to help a > little on the review. > > On Mon, Mar 16, 2020 at 02:40:00PM

Re: [PATCH v7 3/5] virtio-iommu: Call iommu notifier for attach/detach

2020-03-16 Thread Jean-Philippe Brucker
Hi Bharat, Could you Cc me on your next posting? Unfortunately I don't have much hardware for testing this at the moment, but I might be able to help a little on the review. On Mon, Mar 16, 2020 at 02:40:00PM +0530, Bharat Bhushan wrote: > > >>> First issue is: your guest can use 4K page and

Re: [PATCH v7 3/5] virtio-iommu: Call iommu notifier for attach/detach

2020-03-16 Thread Bharat Bhushan
Hi Eric, On Mon, Mar 16, 2020 at 1:15 PM Bharat Bhushan wrote: > > Hi Eric, > > On Mon, Mar 16, 2020 at 1:02 PM Auger Eric wrote: > > > > Hi Bharat, > > > > On 3/16/20 7:41 AM, Bharat Bhushan wrote: > > > Hi Eric, > > > > > > On Fri, Mar 13, 2020 at 8:11 PM Auger Eric wrote: > > >> > > >> Hi

Re: [PATCH v7 3/5] virtio-iommu: Call iommu notifier for attach/detach

2020-03-16 Thread Bharat Bhushan
Hi Eric, On Mon, Mar 16, 2020 at 2:35 PM Auger Eric wrote: > > Hi Bharat, > > On 3/16/20 9:58 AM, Bharat Bhushan wrote: > > Hi Eric, > > > > On Mon, Mar 16, 2020 at 1:15 PM Bharat Bhushan > > wrote: > >> > >> Hi Eric, > >> > >> On Mon, Mar 16, 2020 at 1:02 PM Auger Eric wrote: > >>> > >>> Hi

Re: [PATCH v7 3/5] virtio-iommu: Call iommu notifier for attach/detach

2020-03-16 Thread Auger Eric
Hi Bharat, On 3/16/20 9:58 AM, Bharat Bhushan wrote: > Hi Eric, > > On Mon, Mar 16, 2020 at 1:15 PM Bharat Bhushan > wrote: >> >> Hi Eric, >> >> On Mon, Mar 16, 2020 at 1:02 PM Auger Eric wrote: >>> >>> Hi Bharat, >>> >>> On 3/16/20 7:41 AM, Bharat Bhushan wrote: Hi Eric, On

Re: [PATCH v7 3/5] virtio-iommu: Call iommu notifier for attach/detach

2020-03-16 Thread Bharat Bhushan
Hi Eric, On Mon, Mar 16, 2020 at 1:02 PM Auger Eric wrote: > > Hi Bharat, > > On 3/16/20 7:41 AM, Bharat Bhushan wrote: > > Hi Eric, > > > > On Fri, Mar 13, 2020 at 8:11 PM Auger Eric wrote: > >> > >> Hi Bharat > >> > >> On 3/13/20 8:48 AM, Bharat Bhushan wrote: > >>> iommu-notifier are called

Re: [PATCH v7 3/5] virtio-iommu: Call iommu notifier for attach/detach

2020-03-16 Thread Auger Eric
Hi Bharat, On 3/16/20 7:41 AM, Bharat Bhushan wrote: > Hi Eric, > > On Fri, Mar 13, 2020 at 8:11 PM Auger Eric wrote: >> >> Hi Bharat >> >> On 3/13/20 8:48 AM, Bharat Bhushan wrote: >>> iommu-notifier are called when a device is attached >> IOMMU notifiers >>> or detached to as address-space.

Re: [PATCH v7 3/5] virtio-iommu: Call iommu notifier for attach/detach

2020-03-16 Thread Bharat Bhushan
Hi Eric, On Fri, Mar 13, 2020 at 8:11 PM Auger Eric wrote: > > Hi Bharat > > On 3/13/20 8:48 AM, Bharat Bhushan wrote: > > iommu-notifier are called when a device is attached > IOMMU notifiers > > or detached to as address-space. > > This is needed for VFIO. > and vhost for detach > > > >

Re: [PATCH v7 3/5] virtio-iommu: Call iommu notifier for attach/detach

2020-03-13 Thread Auger Eric
Hi Bharat On 3/13/20 8:48 AM, Bharat Bhushan wrote: > iommu-notifier are called when a device is attached IOMMU notifiers > or detached to as address-space. > This is needed for VFIO. and vhost for detach > > Signed-off-by: Bharat Bhushan > --- > hw/virtio/virtio-iommu.c | 47

[PATCH v7 3/5] virtio-iommu: Call iommu notifier for attach/detach

2020-03-13 Thread Bharat Bhushan
iommu-notifier are called when a device is attached or detached to as address-space. This is needed for VFIO. Signed-off-by: Bharat Bhushan --- hw/virtio/virtio-iommu.c | 47 1 file changed, 47 insertions(+) diff --git a/hw/virtio/virtio-iommu.c