Re: [PATCH v7 4/5] crypto: Add tls-cipher-suites object

2020-05-29 Thread Laszlo Ersek
On 05/29/20 13:18, Daniel P. Berrangé wrote: > On Fri, May 29, 2020 at 01:09:22PM +0200, Laszlo Ersek wrote: >> On 05/28/20 19:31, Philippe Mathieu-Daudé wrote: >> (2) We need an actual commit message for this patch. How about the >> following -- I have liberally stolen and edited comments that

Re: [PATCH v7 4/5] crypto: Add tls-cipher-suites object

2020-05-29 Thread Daniel P . Berrangé
On Fri, May 29, 2020 at 01:09:22PM +0200, Laszlo Ersek wrote: > On 05/28/20 19:31, Philippe Mathieu-Daudé wrote: > (2) We need an actual commit message for this patch. How about the > following -- I have liberally stolen and edited comments that Daniel > made earlier in the Red Hat Bugzilla: > >

Re: [PATCH v7 4/5] crypto: Add tls-cipher-suites object

2020-05-29 Thread Laszlo Ersek
On 05/29/20 13:09, Laszlo Ersek wrote: > On 05/28/20 19:31, Philippe Mathieu-Daudé wrote: >> Example of use to dump: >> >> $ qemu-system-x86_64 -S \ >> -object tls-cipher-suites,id=mysuite,priority=@SYSTEM \ >> -trace qcrypto\* >> 159066.197123:qcrypto_tls_cipher_suite_priority

Re: [PATCH v7 4/5] crypto: Add tls-cipher-suites object

2020-05-29 Thread Laszlo Ersek
On 05/28/20 19:31, Philippe Mathieu-Daudé wrote: > Example of use to dump: > > $ qemu-system-x86_64 -S \ > -object tls-cipher-suites,id=mysuite,priority=@SYSTEM \ > -trace qcrypto\* > 159066.197123:qcrypto_tls_cipher_suite_priority priority: @SYSTEM >

[PATCH v7 4/5] crypto: Add tls-cipher-suites object

2020-05-28 Thread Philippe Mathieu-Daudé
Example of use to dump: $ qemu-system-x86_64 -S \ -object tls-cipher-suites,id=mysuite,priority=@SYSTEM \ -trace qcrypto\* 159066.197123:qcrypto_tls_cipher_suite_priority priority: @SYSTEM 159066.197219:qcrypto_tls_cipher_suite_info data:[0x13, 0x02] version:TLS1.3