On Tue, Jan 26, 2021 at 12:08 AM Philippe Mathieu-Daudé
wrote:
> On 1/26/21 6:55 AM, Joelle van Dyne wrote:
> > Previously, the only case where sys/disk.h does not exist is on
> > platforms that define __DragonFly__. However, iOS also does not have
> > this header. Previously, I had it as
> >
>
On 1/26/21 8:08 AM, Philippe Mathieu-Daudé wrote:
> On 1/26/21 6:55 AM, Joelle van Dyne wrote:
>> Previously, the only case where sys/disk.h does not exist is on
>> platforms that define __DragonFly__. However, iOS also does not have
>> this header. Previously, I had it as
>>
>> #if
On 1/26/21 6:55 AM, Joelle van Dyne wrote:
> Previously, the only case where sys/disk.h does not exist is on
> platforms that define __DragonFly__. However, iOS also does not have
> this header. Previously, I had it as
>
> #if defined(__DragonFly__) || defined(CONFIG_IOS)
>
> But there was a
On Mon, Jan 25, 2021 at 10:55 PM Joelle van Dyne wrote:
> Previously, the only case where sys/disk.h does not exist is on
> platforms that define __DragonFly__. However, iOS also does not have
> this header. Previously, I had it as
>
> #if defined(__DragonFly__) || defined(CONFIG_IOS)
>
> But
Previously, the only case where sys/disk.h does not exist is on
platforms that define __DragonFly__. However, iOS also does not have
this header. Previously, I had it as
#if defined(__DragonFly__) || defined(CONFIG_IOS)
But there was a code review comment that we should use feature flags
instead
On Mon, Jan 25, 2021 at 6:33 PM Joelle van Dyne wrote:
> Some BSD platforms do not have this header.
>
> Signed-off-by: Joelle van Dyne
> ---
> meson.build| 1 +
> block.c| 2 +-
> block/file-posix.c | 2 +-
> 3 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git
Some BSD platforms do not have this header.
Signed-off-by: Joelle van Dyne
---
meson.build| 1 +
block.c| 2 +-
block/file-posix.c | 2 +-
3 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/meson.build b/meson.build
index 27110075df..6818d97df5 100644
---
