Re: [PULL 0/1] loongarch-to-apply queue
在 2024/2/22 下午8:42, Peter Maydell 写道: On Wed, 21 Feb 2024 at 09:11, Song Gao wrote: The following changes since commit 760b4dcdddba4a40b9fa0eb78fdfc7eda7cb83d0: Merge tag 'for-upstream' of https://gitlab.com/bonzini/qemu into staging (2024-02-20 10:11:08 +) are available in the Git repository at: https://gitlab.com/gaosong/qemu.git tags/pull-loongarch-20240221 for you to fetch changes up to be57fd1e526e70fd55f1e87b0b70fab3c6baf089: loongarch: Change the UEFI loading mode to loongarch (2024-02-21 17:06:23 +0800) pull-loongarch-20240221 Xianglai Li (1): loongarch: Change the UEFI loading mode to loongarch Hi; this fails to build for mipsel: https://gitlab.com/qemu-project/qemu/-/jobs/6232698129 ../hw/loongarch/acpi-build.c: In function ‘build_flash_aml’: ../hw/loongarch/acpi-build.c:327:19: error: incompatible types when assigning to type ‘hwaddr’ {aka ‘long long unsigned int’} from type ‘Int128’ 327 | flash0_size = flash_mem->size; | ^ ../hw/loongarch/acpi-build.c:331:19: error: incompatible types when assigning to type ‘hwaddr’ {aka ‘long long unsigned int’} from type ‘Int128’ 331 | flash1_size = flash_mem->size; | ^ ../hw/loongarch/virt.c: In function ‘fdt_add_flash_node’: ../hw/loongarch/virt.c:131:19: error: incompatible types when assigning to type ‘hwaddr’ {aka ‘long long unsigned int’} from type ‘Int128’ 131 | flash0_size = flash_mem->size; | ^ ../hw/loongarch/virt.c:135:19: error: incompatible types when assigning to type ‘hwaddr’ {aka ‘long long unsigned int’} from type ‘Int128’ 135 | flash1_size = flash_mem->size; | ^ The value you get back from pflash_cfi01_get_memory() is a MemoryRegion -- this should be an opaque struct to you, not something you can reach in and get the 'size' field from. (The 'size' field is an Int128, which is not necessarily an integer type known to the compiler -- on some platforms it is a struct -- which is why this doesn't compile here.) Your board code created these memory regions so typically it should already know how big they are. If you really do need to get the size of a MemoryRegion, the function to use is memory_region_size( Got it , I will correct it. Thanks. Song Gao thanks -- PMM
Re: [PULL 0/1] loongarch-to-apply queue
On Wed, 21 Feb 2024 at 09:11, Song Gao wrote: > > The following changes since commit 760b4dcdddba4a40b9fa0eb78fdfc7eda7cb83d0: > > Merge tag 'for-upstream' of https://gitlab.com/bonzini/qemu into staging > (2024-02-20 10:11:08 +) > > are available in the Git repository at: > > https://gitlab.com/gaosong/qemu.git tags/pull-loongarch-20240221 > > for you to fetch changes up to be57fd1e526e70fd55f1e87b0b70fab3c6baf089: > > loongarch: Change the UEFI loading mode to loongarch (2024-02-21 17:06:23 > +0800) > > > pull-loongarch-20240221 > > > Xianglai Li (1): > loongarch: Change the UEFI loading mode to loongarch Hi; this fails to build for mipsel: https://gitlab.com/qemu-project/qemu/-/jobs/6232698129 ../hw/loongarch/acpi-build.c: In function ‘build_flash_aml’: ../hw/loongarch/acpi-build.c:327:19: error: incompatible types when assigning to type ‘hwaddr’ {aka ‘long long unsigned int’} from type ‘Int128’ 327 | flash0_size = flash_mem->size; | ^ ../hw/loongarch/acpi-build.c:331:19: error: incompatible types when assigning to type ‘hwaddr’ {aka ‘long long unsigned int’} from type ‘Int128’ 331 | flash1_size = flash_mem->size; | ^ ../hw/loongarch/virt.c: In function ‘fdt_add_flash_node’: ../hw/loongarch/virt.c:131:19: error: incompatible types when assigning to type ‘hwaddr’ {aka ‘long long unsigned int’} from type ‘Int128’ 131 | flash0_size = flash_mem->size; | ^ ../hw/loongarch/virt.c:135:19: error: incompatible types when assigning to type ‘hwaddr’ {aka ‘long long unsigned int’} from type ‘Int128’ 135 | flash1_size = flash_mem->size; | ^ The value you get back from pflash_cfi01_get_memory() is a MemoryRegion -- this should be an opaque struct to you, not something you can reach in and get the 'size' field from. (The 'size' field is an Int128, which is not necessarily an integer type known to the compiler -- on some platforms it is a struct -- which is why this doesn't compile here.) Your board code created these memory regions so typically it should already know how big they are. If you really do need to get the size of a MemoryRegion, the function to use is memory_region_size(). thanks -- PMM
[PULL 0/1] loongarch-to-apply queue
The following changes since commit 760b4dcdddba4a40b9fa0eb78fdfc7eda7cb83d0: Merge tag 'for-upstream' of https://gitlab.com/bonzini/qemu into staging (2024-02-20 10:11:08 +) are available in the Git repository at: https://gitlab.com/gaosong/qemu.git tags/pull-loongarch-20240221 for you to fetch changes up to be57fd1e526e70fd55f1e87b0b70fab3c6baf089: loongarch: Change the UEFI loading mode to loongarch (2024-02-21 17:06:23 +0800) pull-loongarch-20240221 Xianglai Li (1): loongarch: Change the UEFI loading mode to loongarch hw/loongarch/acpi-build.c | 29 +++-- hw/loongarch/virt.c | 101 include/hw/loongarch/virt.h | 10 +++-- 3 files changed, 107 insertions(+), 33 deletions(-)
Re: [PULL 0/1] loongarch-to-apply queue
On Thu, 1 Feb 2024 at 07:33, Song Gao wrote: > > The following changes since commit bd2e12310b18b51aefbf834e6d54989fd175976f: > > Merge tag 'qga-pull-2024-01-30' of https://github.com/kostyanf14/qemu into > staging (2024-01-30 15:53:46 +) > > are available in the Git repository at: > > https://gitlab.com/gaosong/qemu.git tags/pull-loongarch-20240201 > > for you to fetch changes up to 27edd5040cae63bfa92c68f69883ba81aa3b6cda: > > target/loongarch: Fix qtest test-hmp error when KVM-only build (2024-02-01 > 15:29:40 +0800) > > > pull-loongarch-20240201 > > > Song Gao (1): > target/loongarch: Fix qtest test-hmp error when KVM-only build > Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/9.0 for any user-visible changes. -- PMM
[PULL 0/1] loongarch-to-apply queue
The following changes since commit bd2e12310b18b51aefbf834e6d54989fd175976f: Merge tag 'qga-pull-2024-01-30' of https://github.com/kostyanf14/qemu into staging (2024-01-30 15:53:46 +) are available in the Git repository at: https://gitlab.com/gaosong/qemu.git tags/pull-loongarch-20240201 for you to fetch changes up to 27edd5040cae63bfa92c68f69883ba81aa3b6cda: target/loongarch: Fix qtest test-hmp error when KVM-only build (2024-02-01 15:29:40 +0800) pull-loongarch-20240201 Song Gao (1): target/loongarch: Fix qtest test-hmp error when KVM-only build target/loongarch/cpu.c| 2 - target/loongarch/cpu_helper.c | 231 ++ target/loongarch/internals.h | 20 +++- target/loongarch/meson.build | 1 + target/loongarch/tcg/tlb_helper.c | 230 - 5 files changed, 250 insertions(+), 234 deletions(-) create mode 100644 target/loongarch/cpu_helper.c
Re: [PULL 0/1] loongarch-to-apply queue
On 6/4/23 20:18, Song Gao wrote: The following changes since commit 848a6caa88b9f082c89c9b41afa975761262981d: Merge tag 'migration-20230602-pull-request' ofhttps://gitlab.com/juan.quintela/qemu into staging (2023-06-02 17:33:29 -0700) are available in the Git repository at: https://gitlab.com/gaosong/qemu.git tags/pull-loongarch-20230605 for you to fetch changes up to 8555ddc671203969b0e6eb651e538d02a9a79b3a: hw/intc/loongarch_ipi: Bring back all 4 IPI mailboxes (2023-06-05 11:08:55 +0800) Fixes Coverity CID: 1512452, 1512453 Fixes: 78464f023b54 ("hw/loongarch/virt: Modify ipi as percpu device") Applied, thanks. Please update https://wiki.qemu.org/ChangeLog/8.1 as appropriate. r~
[PULL 0/1] loongarch-to-apply queue
The following changes since commit 848a6caa88b9f082c89c9b41afa975761262981d: Merge tag 'migration-20230602-pull-request' of https://gitlab.com/juan.quintela/qemu into staging (2023-06-02 17:33:29 -0700) are available in the Git repository at: https://gitlab.com/gaosong/qemu.git tags/pull-loongarch-20230605 for you to fetch changes up to 8555ddc671203969b0e6eb651e538d02a9a79b3a: hw/intc/loongarch_ipi: Bring back all 4 IPI mailboxes (2023-06-05 11:08:55 +0800) Fixes Coverity CID: 1512452, 1512453 Fixes: 78464f023b54 ("hw/loongarch/virt: Modify ipi as percpu device") Jiaxun Yang (1): hw/intc/loongarch_ipi: Bring back all 4 IPI mailboxes hw/intc/loongarch_ipi.c | 6 +++--- include/hw/intc/loongarch_ipi.h | 4 +++- 2 files changed, 6 insertions(+), 4 deletions(-)
Re: [PULL 0/1] loongarch-to-apply queue
On Thu, 15 Dec 2022 at 08:11, Song Gao wrote: > > The following changes since commit 5204b499a6cae4dfd9fe762d5e6e82224892383b: > > mailmap: Fix Stefan Weil author email (2022-12-13 15:56:57 -0500) > > are available in the Git repository at: > > https://gitlab.com/gaosong/qemu.git tags/pull-loongarch-20221215 > > for you to fetch changes up to 288431a1fb9334d5d57ad7d5854d8475b23e7c42: > > hw/loongarch/virt: Add cfi01 pflash device (2022-12-15 15:46:12 +0800) > > > Add cfi01 pflash device > > > Xiaojuan Yang (1): > hw/loongarch/virt: Add cfi01 pflash device Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/8.0 for any user-visible changes. -- PMM
[PULL 0/1] loongarch-to-apply queue
The following changes since commit 5204b499a6cae4dfd9fe762d5e6e82224892383b: mailmap: Fix Stefan Weil author email (2022-12-13 15:56:57 -0500) are available in the Git repository at: https://gitlab.com/gaosong/qemu.git tags/pull-loongarch-20221215 for you to fetch changes up to 288431a1fb9334d5d57ad7d5854d8475b23e7c42: hw/loongarch/virt: Add cfi01 pflash device (2022-12-15 15:46:12 +0800) Add cfi01 pflash device Xiaojuan Yang (1): hw/loongarch/virt: Add cfi01 pflash device hw/loongarch/Kconfig| 1 + hw/loongarch/acpi-build.c | 18 + hw/loongarch/virt.c | 62 + include/hw/loongarch/virt.h | 5 4 files changed, 86 insertions(+)