Re: [PULL 1/5] hw/pcie-root-port: Fix hotplug for PCI devices requiring IO

2021-11-02 Thread Julia Suvorova
On Tue, Nov 2, 2021 at 10:26 AM Daniel P. Berrangé wrote: > > On Mon, Sep 27, 2021 at 05:49:15AM -0400, Michael S. Tsirkin wrote: > > On Mon, Sep 27, 2021 at 10:33:42AM +0100, Daniel P. Berrangé wrote: > > > On Tue, Aug 03, 2021 at 04:52:03PM -0400, Michael S. Tsirkin wrote: > > > > From: Marcel

Re: [PULL 1/5] hw/pcie-root-port: Fix hotplug for PCI devices requiring IO

2021-11-02 Thread Marcel Apfelbaum
Hi Daniel, On Tue, Nov 2, 2021 at 11:24 AM Daniel P. Berrangé wrote: > On Mon, Sep 27, 2021 at 05:49:15AM -0400, Michael S. Tsirkin wrote: > > On Mon, Sep 27, 2021 at 10:33:42AM +0100, Daniel P. Berrangé wrote: > > > On Tue, Aug 03, 2021 at 04:52:03PM -0400, Michael S. Tsirkin wrote: > > > >

Re: [PULL 1/5] hw/pcie-root-port: Fix hotplug for PCI devices requiring IO

2021-11-02 Thread Daniel P . Berrangé
On Mon, Sep 27, 2021 at 05:49:15AM -0400, Michael S. Tsirkin wrote: > On Mon, Sep 27, 2021 at 10:33:42AM +0100, Daniel P. Berrangé wrote: > > On Tue, Aug 03, 2021 at 04:52:03PM -0400, Michael S. Tsirkin wrote: > > > From: Marcel Apfelbaum > > > > > > Q35 has now ACPI hotplug enabled by default

Re: [PULL 1/5] hw/pcie-root-port: Fix hotplug for PCI devices requiring IO

2021-09-30 Thread Michael S. Tsirkin
On Thu, Sep 30, 2021 at 10:34:24AM +0200, Igor Mammedov wrote: > On Wed, 29 Sep 2021 17:47:37 -0400 > "Michael S. Tsirkin" wrote: > > > On Wed, Sep 29, 2021 at 04:41:49PM +0300, Marcel Apfelbaum wrote: > > > Hi Michael, > > > > > > On Mon, Sep 27, 2021 at 12:49 PM Michael S. Tsirkin > > >

Re: [PULL 1/5] hw/pcie-root-port: Fix hotplug for PCI devices requiring IO

2021-09-30 Thread Igor Mammedov
On Wed, 29 Sep 2021 17:47:37 -0400 "Michael S. Tsirkin" wrote: > On Wed, Sep 29, 2021 at 04:41:49PM +0300, Marcel Apfelbaum wrote: > > Hi Michael, > > > > On Mon, Sep 27, 2021 at 12:49 PM Michael S. Tsirkin wrote: > > > > On Mon, Sep 27, 2021 at 10:33:42AM +0100, Daniel P. Berrangé wrote:

Re: [PULL 1/5] hw/pcie-root-port: Fix hotplug for PCI devices requiring IO

2021-09-29 Thread Michael S. Tsirkin
On Wed, Sep 29, 2021 at 04:41:49PM +0300, Marcel Apfelbaum wrote: > Hi Michael, > > On Mon, Sep 27, 2021 at 12:49 PM Michael S. Tsirkin wrote: > > On Mon, Sep 27, 2021 at 10:33:42AM +0100, Daniel P. Berrangé wrote: > > On Tue, Aug 03, 2021 at 04:52:03PM -0400, Michael S. Tsirkin wrote:

Re: [PULL 1/5] hw/pcie-root-port: Fix hotplug for PCI devices requiring IO

2021-09-29 Thread Gerd Hoffmann
Hi, > > generally maybe we should just add an ACPI-hotplug capability and > > teach seabios about it? > > I suppose it is possible. I doubt this solves the problem. As I understand it linux will happily assign io address space for pcie hotplug root ports but not for acpi hotplug root ports.

Re: [PULL 1/5] hw/pcie-root-port: Fix hotplug for PCI devices requiring IO

2021-09-29 Thread Marcel Apfelbaum
Hi Daniel, On Wed, Sep 29, 2021 at 12:05 PM Daniel P. Berrangé wrote: > On Mon, Sep 27, 2021 at 05:49:15AM -0400, Michael S. Tsirkin wrote: > > On Mon, Sep 27, 2021 at 10:33:42AM +0100, Daniel P. Berrangé wrote: > > > On Tue, Aug 03, 2021 at 04:52:03PM -0400, Michael S. Tsirkin wrote: > > > >

Re: [PULL 1/5] hw/pcie-root-port: Fix hotplug for PCI devices requiring IO

2021-09-29 Thread Marcel Apfelbaum
Hi Michael, On Mon, Sep 27, 2021 at 12:49 PM Michael S. Tsirkin wrote: > On Mon, Sep 27, 2021 at 10:33:42AM +0100, Daniel P. Berrangé wrote: > > On Tue, Aug 03, 2021 at 04:52:03PM -0400, Michael S. Tsirkin wrote: > > > From: Marcel Apfelbaum > > > > > > Q35 has now ACPI hotplug enabled by

Re: [PULL 1/5] hw/pcie-root-port: Fix hotplug for PCI devices requiring IO

2021-09-29 Thread Daniel P . Berrangé
On Mon, Sep 27, 2021 at 05:49:15AM -0400, Michael S. Tsirkin wrote: > On Mon, Sep 27, 2021 at 10:33:42AM +0100, Daniel P. Berrangé wrote: > > On Tue, Aug 03, 2021 at 04:52:03PM -0400, Michael S. Tsirkin wrote: > > > From: Marcel Apfelbaum > > > > > > Q35 has now ACPI hotplug enabled by default

Re: [PULL 1/5] hw/pcie-root-port: Fix hotplug for PCI devices requiring IO

2021-09-27 Thread Michael S. Tsirkin
On Mon, Sep 27, 2021 at 10:33:42AM +0100, Daniel P. Berrangé wrote: > On Tue, Aug 03, 2021 at 04:52:03PM -0400, Michael S. Tsirkin wrote: > > From: Marcel Apfelbaum > > > > Q35 has now ACPI hotplug enabled by default for PCI(e) devices. > > As opposed to native PCIe hotplug, guests like Fedora

Re: [PULL 1/5] hw/pcie-root-port: Fix hotplug for PCI devices requiring IO

2021-09-27 Thread Daniel P . Berrangé
On Tue, Aug 03, 2021 at 04:52:03PM -0400, Michael S. Tsirkin wrote: > From: Marcel Apfelbaum > > Q35 has now ACPI hotplug enabled by default for PCI(e) devices. > As opposed to native PCIe hotplug, guests like Fedora 34 > will not assign IO range to pcie-root-ports not supporting > native

[PULL 1/5] hw/pcie-root-port: Fix hotplug for PCI devices requiring IO

2021-08-03 Thread Michael S. Tsirkin
From: Marcel Apfelbaum Q35 has now ACPI hotplug enabled by default for PCI(e) devices. As opposed to native PCIe hotplug, guests like Fedora 34 will not assign IO range to pcie-root-ports not supporting native hotplug, resulting into a regression. Reproduce by: qemu-bin -M q35 -device