Re: [PULL 16/21] hw/timer: Refactor NPCM7XX Timer to use CLK clock

2021-07-27 Thread Havard Skinnemoen
On Tue, Jul 27, 2021 at 7:19 AM Peter Maydell wrote: > > On Thu, 4 Feb 2021 at 22:38, Hao Wu wrote: > > > > I don't see this error. It could be some error in the clock that the timer > > module does not get a correct clock input. > > How do you reproduce this? > > > > On Thu, Feb 4, 2021 at

Re: [PULL 16/21] hw/timer: Refactor NPCM7XX Timer to use CLK clock

2021-07-27 Thread Peter Maydell
On Thu, 4 Feb 2021 at 22:38, Hao Wu wrote: > > I don't see this error. It could be some error in the clock that the timer > module does not get a correct clock input. > How do you reproduce this? > > On Thu, Feb 4, 2021 at 1:39 AM Philippe Mathieu-Daudé wrote: >> >> Hi, >> >> On Tue, Jan 12,

Re: [PULL 16/21] hw/timer: Refactor NPCM7XX Timer to use CLK clock

2021-06-22 Thread Philippe Mathieu-Daudé
On 2/10/21 12:54 PM, Philippe Mathieu-Daudé wrote: > On 2/4/21 11:37 PM, Hao Wu wrote: >> I don't see this error. It could be some error in the clock that the >> timer module does not get a correct clock input. >> How do you reproduce this? > > I got it only once, can not reproduce, but it

Re: [PULL 16/21] hw/timer: Refactor NPCM7XX Timer to use CLK clock

2021-02-10 Thread Philippe Mathieu-Daudé
On 2/4/21 11:37 PM, Hao Wu wrote: > I don't see this error. It could be some error in the clock that the > timer module does not get a correct clock input. > How do you reproduce this? I got it only once, can not reproduce, but it happened on our CI too:

Re: [PULL 16/21] hw/timer: Refactor NPCM7XX Timer to use CLK clock

2021-02-04 Thread Hao Wu
I don't see this error. It could be some error in the clock that the timer module does not get a correct clock input. How do you reproduce this? On Thu, Feb 4, 2021 at 1:39 AM Philippe Mathieu-Daudé wrote: > Hi, > > On Tue, Jan 12, 2021 at 6:20 PM Peter Maydell > wrote: > > > > From: Hao Wu >

Re: [PULL 16/21] hw/timer: Refactor NPCM7XX Timer to use CLK clock

2021-02-04 Thread Philippe Mathieu-Daudé
Hi, On Tue, Jan 12, 2021 at 6:20 PM Peter Maydell wrote: > > From: Hao Wu > > This patch makes NPCM7XX Timer to use a the timer clock generated by the > CLK module instead of the magic number TIMER_REF_HZ. > > Reviewed-by: Havard Skinnemoen > Reviewed-by: Tyrone Ting > Signed-off-by: Hao Wu

[PULL 16/21] hw/timer: Refactor NPCM7XX Timer to use CLK clock

2021-01-12 Thread Peter Maydell
From: Hao Wu This patch makes NPCM7XX Timer to use a the timer clock generated by the CLK module instead of the magic number TIMER_REF_HZ. Reviewed-by: Havard Skinnemoen Reviewed-by: Tyrone Ting Signed-off-by: Hao Wu Message-id: 20210108190945.949196-3-wuhao...@google.com Reviewed-by: Peter