Re: [PULL v2 13/15] hw/rx: Add RX GDB simulator

2020-10-01 Thread Philippe Mathieu-Daudé
On 9/9/20 7:56 PM, Philippe Mathieu-Daudé wrote: > Hi Yoshinori, > > On 9/7/20 3:13 PM, Peter Maydell wrote: >> On Mon, 22 Jun 2020 at 20:20, Philippe Mathieu-Daudé wrote: >>> >>> From: Yoshinori Sato >>> >>> Add the RX machine internally simulated in GDB. >> >> Hi; Coverity points out a memory

Re: [PULL v2 13/15] hw/rx: Add RX GDB simulator

2020-09-09 Thread Philippe Mathieu-Daudé
Hi Yoshinori, On 9/7/20 3:13 PM, Peter Maydell wrote: > On Mon, 22 Jun 2020 at 20:20, Philippe Mathieu-Daudé wrote: >> >> From: Yoshinori Sato >> >> Add the RX machine internally simulated in GDB. > > Hi; Coverity points out a memory leak (CID 1432307) in this function: > >> +static void

Re: [PULL v2 13/15] hw/rx: Add RX GDB simulator

2020-09-07 Thread Peter Maydell
On Mon, 22 Jun 2020 at 20:20, Philippe Mathieu-Daudé wrote: > > From: Yoshinori Sato > > Add the RX machine internally simulated in GDB. Hi; Coverity points out a memory leak (CID 1432307) in this function: > +static void rx_gdbsim_init(MachineState *machine) > +{ > +if (dtb_filename)

[PULL v2 13/15] hw/rx: Add RX GDB simulator

2020-06-22 Thread Philippe Mathieu-Daudé
From: Yoshinori Sato Add the RX machine internally simulated in GDB. Signed-off-by: Yoshinori Sato Tested-by: Philippe Mathieu-Daudé Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson [PMD: Use TYPE_RX62N_CPU, use #define for RX62N_NR_TMR/CMT/SCI, renamed CPU -> MCU,