Re: [Ping][PATCH v0] vl: flush all task from rcu queue before exiting

2021-11-10 Thread Paolo Bonzini
On 11/10/21 14:29, Denis Plotnikov wrote: On 09.11.2021 20:46, Paolo Bonzini wrote: On 11/9/21 08:23, Denis Plotnikov wrote: Ping ping! Looks good, but can you explain why it's okay to call it before qemu_chr_cleanup() and user_creatable_cleanup()? I think a better solution to the

Re: [Ping][PATCH v0] vl: flush all task from rcu queue before exiting

2021-11-10 Thread Denis Plotnikov
On 09.11.2021 20:46, Paolo Bonzini wrote: On 11/9/21 08:23, Denis Plotnikov wrote: Ping ping! Looks good, but can you explain why it's okay to call it before qemu_chr_cleanup() and user_creatable_cleanup()? I think a better solution to the ordering problem would be:  

Re: [Ping][PATCH v0] vl: flush all task from rcu queue before exiting

2021-11-09 Thread Paolo Bonzini
On 11/9/21 08:23, Denis Plotnikov wrote: Ping ping! Looks good, but can you explain why it's okay to call it before qemu_chr_cleanup() and user_creatable_cleanup()? I think a better solution to the ordering problem would be: qemu_chr_cleanup(); user_creatable_cleanup(); flush_rcu();

[Ping][PATCH v0] vl: flush all task from rcu queue before exiting

2021-11-08 Thread Denis Plotnikov
Ping ping! On 02.11.2021 16:39, Denis Plotnikov wrote: The device destruction may superimpose over qemu shutdown. In this case some management layer, requested a device unplug and waiting for DEVICE_DELETED event, may never get this event. This happens because device_finalize() may never be