On Tue, Mar 15, 2016 at 06:26:05PM +0530, rutuja shah wrote:
> On Tue, Mar 15, 2016 at 6:01 PM, Stefan Hajnoczi wrote:
> > On Mon, Mar 14, 2016 at 06:29:06PM +0530, rutuja shah wrote:
> >> > What is the benefit of adding the NULL checks? The only difference I
> >> > see is
Regards
Rutuja Shah
On Tue, Mar 15, 2016 at 6:01 PM, Stefan Hajnoczi wrote:
> On Mon, Mar 14, 2016 at 06:29:06PM +0530, rutuja shah wrote:
>> > What is the benefit of adding the NULL checks? The only difference I
>> > see is that the error message from load_elf() is
On Mon, Mar 14, 2016 at 06:29:06PM +0530, rutuja shah wrote:
> > What is the benefit of adding the NULL checks? The only difference I
> > see is that the error message from load_elf() is silenced.
> Yes, in case of load_elf, error message is silenced. The immediate
> call to load_uimage()
> is
On 03/12/2016 01:36 PM, rutu.shah...@gmail.com wrote:
> From: Rutuja Shah
>
> This patch adds NULL check for return value from qemu_find_file(), where it
> is missing. It avoids unnecessary function calls with NULL parameter which in
> turn return -1. Especially, incase
Regards
Rutuja Shah
On Mon, Mar 14, 2016 at 5:14 PM, Stefan Hajnoczi wrote:
> On Sun, Mar 13, 2016 at 02:06:34AM +0530, rutu.shah...@gmail.com wrote:
>> From: Rutuja Shah
>>
>> This patch adds NULL check for return value from qemu_find_file(), where
On Sun, Mar 13, 2016 at 02:06:34AM +0530, rutu.shah...@gmail.com wrote:
> From: Rutuja Shah
>
> This patch adds NULL check for return value from qemu_find_file(), where it
> is missing. It avoids unnecessary function calls with NULL parameter which in
> turn return -1.
From: Rutuja Shah
This patch adds NULL check for return value from qemu_find_file(), where it is
missing. It avoids unnecessary function calls with NULL parameter which in turn
return -1. Especially, incase of load_uimage(), two functions are called which
return -1 on