Re: [Qemu-devel] [PATCH] Fix -snapshot deleting CDROM images

2010-07-26 Thread Markus Armbruster
Blue Swirl blauwir...@gmail.com writes: On Sat, Jul 24, 2010 at 12:03 PM, Markus Armbruster arm...@redhat.com wrote: Blue Swirl blauwir...@gmail.com writes: Command line flag '-snapshot' was setting the drive flag 'snapshot' for all drives. Therefore also CDROM devices were incorrectly

Re: [Qemu-devel] [PATCH] Fix -snapshot deleting CDROM images

2010-07-25 Thread Blue Swirl
On Sat, Jul 24, 2010 at 12:03 PM, Markus Armbruster arm...@redhat.com wrote: Blue Swirl blauwir...@gmail.com writes: Command line flag '-snapshot' was setting the drive flag 'snapshot' for all drives. Therefore also CDROM devices were incorrectly marked with BDRV_O_SNAPSHOT. Thus the backing

Re: [Qemu-devel] [PATCH] Fix -snapshot deleting CDROM images

2010-07-24 Thread Markus Armbruster
Blue Swirl blauwir...@gmail.com writes: Command line flag '-snapshot' was setting the drive flag 'snapshot' for all drives. Therefore also CDROM devices were incorrectly marked with BDRV_O_SNAPSHOT. Thus the backing images were accidentally deleted at bdrv_open time, for example when changing

[Qemu-devel] [PATCH] Fix -snapshot deleting CDROM images

2010-07-23 Thread Blue Swirl
Command line flag '-snapshot' was setting the drive flag 'snapshot' for all drives. Therefore also CDROM devices were incorrectly marked with BDRV_O_SNAPSHOT. Thus the backing images were accidentally deleted at bdrv_open time, for example when changing the image with monitor 'change' command.