Re: [Qemu-devel] [PATCH] Fix mask of pte index

2013-05-22 Thread Andreas Färber
Am 22.05.2013 03:25, schrieb Qiao Nuohan: On 05/22/2013 09:21 AM, Qiao Nuohan wrote: Function walk_pte needs pte index to calculate virtual address. However, pte index of PAE paging or IA-32e paging is 9 bit, so the mask should be 0x1ff. Signed-off-by: Qiao Nuohan qiaonuo...@cn.fujitsu.com

Re: [Qemu-devel] [PATCH] Fix mask of pte index

2013-05-21 Thread Andreas Färber
Nuohan, Am 21.05.2013 08:16, schrieb Jesse Larrew: On 05/20/2013 10:00 PM, Qiao Nuohan wrote: Function walk_pte needs pte index to calculate virtual address. However, pte index of PAE paging or IA-32e paging is 9 bit, so the mask should be 0x1ff. --- target-i386/arch_memory_mapping.c |2

Re: [Qemu-devel] [PATCH] Fix mask of pte index

2013-05-21 Thread Qiao Nuohan
On 05/21/2013 07:32 PM, Andreas Färber wrote: This patch is missing a Signed-off-by! Ha! I forgot it. If you can reply with one, I'd fix up the subject for you (it should indicate where you are fixing it) and queue it together with my CPU'ish memory_mapping refactorings, if no one objects.

Re: [Qemu-devel] [PATCH] Fix mask of pte index

2013-05-21 Thread Andreas Färber
Am 21.05.2013 14:05, schrieb Qiao Nuohan: On 05/21/2013 07:32 PM, Andreas Färber wrote: This patch is missing a Signed-off-by! Ha! I forgot it. If you can reply with one, I'd fix up the subject for you (it should indicate where you are fixing it) and queue it together with my CPU'ish

Re: [Qemu-devel] [PATCH] Fix mask of pte index

2013-05-21 Thread Qiao Nuohan
Function walk_pte needs pte index to calculate virtual address. However, pte index of PAE paging or IA-32e paging is 9 bit, so the mask should be 0x1ff. Signed-off-by: Qiao Nuohan qiaonuo...@cn.fujitsu.com --- target-i386/arch_memory_mapping.c |2 +- 1 files changed, 1 insertions(+), 1

Re: [Qemu-devel] [PATCH] Fix mask of pte index

2013-05-21 Thread Qiao Nuohan
On 05/22/2013 09:21 AM, Qiao Nuohan wrote: Function walk_pte needs pte index to calculate virtual address. However, pte index of PAE paging or IA-32e paging is 9 bit, so the mask should be 0x1ff. Signed-off-by: Qiao Nuohan qiaonuo...@cn.fujitsu.com Reviewed by: Jesse Larrew

Re: [Qemu-devel] [PATCH] Fix mask of pte index

2013-05-21 Thread Jesse Larrew
On 05/20/2013 10:00 PM, Qiao Nuohan wrote: Function walk_pte needs pte index to calculate virtual address. However, pte index of PAE paging or IA-32e paging is 9 bit, so the mask should be 0x1ff. --- target-i386/arch_memory_mapping.c |2 +- 1 files changed, 1 insertions(+), 1

[Qemu-devel] [PATCH] Fix mask of pte index

2013-05-20 Thread Qiao Nuohan
Function walk_pte needs pte index to calculate virtual address. However, pte index of PAE paging or IA-32e paging is 9 bit, so the mask should be 0x1ff. --- target-i386/arch_memory_mapping.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git