Re: [Qemu-devel] [PATCH] New feature - RFC3931 L2TPv3 network transport using static Ethernet over L2TPv3 tunnels

2014-03-10 Thread Stefan Hajnoczi
On Sun, Mar 09, 2014 at 05:06:15PM +, Anton Ivanov wrote: + return -1; +} + +freeaddrinfo(result); + +memset(hints, 0, sizeof(hints)); + +if (s-ipv6) { + hints.ai_family = AF_INET6; +} else { + hints.ai_family = AF_INET; +} +if (s-udp) { +

Re: [Qemu-devel] [PATCH] New feature - RFC3931 L2TPv3 network transport using static Ethernet over L2TPv3 tunnels

2014-03-10 Thread Anton Ivanov
You are correct. My test is wrong. However, the result is the same - it wants a non-zero proto there. $ sudo ./gaitest src ai_family 2 ai_socketype 3 ai_protocol 0 socket creation failed, errno = 93 src ai_family 2 ai_socketype 3 ai_protocol 115 No error on the second one, -93 on the first one.

Re: [Qemu-devel] [PATCH] New feature - RFC3931 L2TPv3 network transport using static Ethernet over L2TPv3 tunnels

2014-03-10 Thread Stefan Hajnoczi
On Mon, Mar 10, 2014 at 08:49:01AM +, Anton Ivanov wrote: You are correct. My test is wrong. However, the result is the same - it wants a non-zero proto there. $ sudo ./gaitest src ai_family 2 ai_socketype 3 ai_protocol 0 socket creation failed, errno = 93 You are right! I got

Re: [Qemu-devel] [PATCH] New feature - RFC3931 L2TPv3 network transport using static Ethernet over L2TPv3 tunnels

2014-03-10 Thread Anton Ivanov (antivano)
On 10/03/14 18:04, Stefan Hajnoczi wrote: On Mon, Mar 10, 2014 at 08:49:01AM +, Anton Ivanov wrote: You are correct. My test is wrong. However, the result is the same - it wants a non-zero proto there. $ sudo ./gaitest src ai_family 2 ai_socketype 3 ai_protocol 0 socket creation

Re: [Qemu-devel] [PATCH] New feature - RFC3931 L2TPv3 network transport using static Ethernet over L2TPv3 tunnels

2014-03-09 Thread Anton Ivanov
+ return -1; +} + +freeaddrinfo(result); + +memset(hints, 0, sizeof(hints)); + +if (s-ipv6) { + hints.ai_family = AF_INET6; +} else { + hints.ai_family = AF_INET; +} +if (s-udp) { + hints.ai_socktype = SOCK_DGRAM; + hints.ai_protocol =

Re: [Qemu-devel] [PATCH] New feature - RFC3931 L2TPv3 network transport using static Ethernet over L2TPv3 tunnels

2014-03-06 Thread Stefan Hajnoczi
On Wed, Mar 05, 2014 at 02:12:20PM +, anton.iva...@kot-begemot.co.uk wrote: Please don't put New feature - in the commit message. net: or l2tpv3: would be a good prefix (see git-log(1) for other examples). The idea behind using a prefix is that you can immediately determine which area of

Re: [Qemu-devel] [PATCH] New feature - RFC3931 L2TPv3 network transport using static Ethernet over L2TPv3 tunnels

2014-03-06 Thread Anton Ivanov
On 06/03/14 09:44, Stefan Hajnoczi wrote: On Wed, Mar 05, 2014 at 02:12:20PM +, anton.iva...@kot-begemot.co.uk wrote: Please don't put New feature - in the commit message. net: or l2tpv3: would be a good prefix (see git-log(1) for other examples). The idea behind using a prefix is that

[Qemu-devel] [PATCH] New feature - RFC3931 L2TPv3 network transport using static Ethernet over L2TPv3 tunnels

2014-03-05 Thread anton . ivanov
From: Anton Ivanov antiv...@cisco.com This transport allows qemu to communicate with host if host supports L2TPv3, communicate directly VM to VM (similar to current socket transport) and VM to other device - f.e. VM to a router. Supported * Raw IPv4, Raw IPv6, UDPv4 and UDPv6 as per RFC

Re: [Qemu-devel] [PATCH] New feature - RFC3931 L2TPv3 network transport using static Ethernet over L2TPv3 tunnels

2014-03-05 Thread Eric Blake
On 03/05/2014 07:12 AM, anton.iva...@kot-begemot.co.uk wrote: From: Anton Ivanov antiv...@cisco.com This transport allows qemu to communicate with host if host supports L2TPv3, communicate directly VM to VM (similar to current socket transport) and VM to other device - f.e. VM to a router.

Re: [Qemu-devel] [PATCH] New feature - RFC3931 L2TPv3 network transport using static Ethernet over L2TPv3 tunnels

2014-03-05 Thread Anton Ivanov
On 05/03/14 21:22, Eric Blake wrote: [snip] udp is layer 3, ip is layer 2 - don't you mean optional for tcp as the layer 3 counterpart of udp? L2TPv3 uses either udp or ip as in raw ip (raw sockets) using a special protocol - 0x73. So no tcp at play here. The wording is incorrect - should be