[Qemu-devel] [PATCH] RFC: options parse in vl.c should be moduled

2012-03-30 Thread Wanpeng Li
Consider of the options parse process in main function of vl.c is too long.It should be module into single function to clear ideas, strengthen the source code management, and increase code readability.So I module the process of options parse as function options_parse, and expose some variables in

Re: [Qemu-devel] [PATCH] RFC: options parse in vl.c should be moduled

2012-03-30 Thread Daniel P. Berrange
On Fri, Mar 30, 2012 at 08:36:43PM +0800, Wanpeng Li wrote: Consider of the options parse process in main function of vl.c is too long.It should be module into single function to clear ideas, strengthen the source code management, and increase code readability.So I module the process of

Re: [Qemu-devel] [PATCH] RFC: options parse in vl.c should be moduled

2012-03-30 Thread Anthony Liguori
On 03/30/2012 07:36 AM, Wanpeng Li wrote: Consider of the options parse process in main function of vl.c is too long.It should be module into single function to clear ideas, strengthen the source code management, and increase code readability.So I module the process of options parse as function

Re: [Qemu-devel] [PATCH] RFC: options parse in vl.c should be moduled

2012-03-30 Thread Wanpeng Li
On Fri, Mar 30, 2012 at 01:53:14PM +0100, Daniel P. Berrange wrote: On Fri, Mar 30, 2012 at 08:36:43PM +0800, Wanpeng Li wrote: Consider of the options parse process in main function of vl.c is too long.It should be module into single function to clear ideas, strengthen the source code

Re: [Qemu-devel] [PATCH] RFC: options parse in vl.c should be moduled

2012-03-30 Thread Michael Roth
On Fri, Mar 30, 2012 at 09:25:47PM +0800, Wanpeng Li wrote: On Fri, Mar 30, 2012 at 01:53:14PM +0100, Daniel P. Berrange wrote: On Fri, Mar 30, 2012 at 08:36:43PM +0800, Wanpeng Li wrote: Consider of the options parse process in main function of vl.c is too long.It should be module into

Re: [Qemu-devel] [PATCH] RFC: options parse in vl.c should be moduled

2012-03-30 Thread Lluís Vilanova
Wanpeng Li writes: Consider of the options parse process in main function of vl.c is too long.It should be module into single function to clear ideas, strengthen the source code management, and increase code readability.So I module the process of options parse as function options_parse, and

Re: [Qemu-devel] [PATCH] RFC: options parse in vl.c should be moduled

2012-03-30 Thread Anthony Liguori
On 03/30/2012 10:59 AM, Lluís Vilanova wrote: Wanpeng Li writes: Consider of the options parse process in main function of vl.c is too long.It should be module into single function to clear ideas, strengthen the source code management, and increase code readability.So I module the process of

Re: [Qemu-devel] [PATCH] RFC: options parse in vl.c should be moduled

2012-03-30 Thread Anthony Liguori
On 03/30/2012 11:09 AM, Anthony Liguori wrote: On 03/30/2012 10:59 AM, Lluís Vilanova wrote: Wanpeng Li writes: Consider of the options parse process in main function of vl.c is too long.It should be module into single function to clear ideas, strengthen the source code management, and

Re: [Qemu-devel] [PATCH] RFC: options parse in vl.c should be moduled

2012-03-30 Thread Lluís Vilanova
Anthony Liguori writes: My plan is to have a -query-capabilities so we can change the help text, then use GOptionContext. It would take a small function that goes through and promotes any option in the format '-foo' to '--foo'. But that's not too hard. Then we can completely rip out the