Re: [Qemu-devel] [PATCH] Use special code for sigsetjmp only in cpu-exec.c

2016-03-01 Thread Stefan Weil
Am 01.03.2016 um 18:54 schrieb Peter Maydell: > On 1 March 2016 at 17:53, Paolo Bonzini wrote: >> >> >> On 01/03/2016 18:46, Andrew Baumann wrote: >>> --- a/include/sysemu/os-win32.h >>> +++ b/include/sysemu/os-win32.h >>> @@ -60,6 +60,7 @@ >>> * If this parameter is NULL,

Re: [Qemu-devel] [PATCH] Use special code for sigsetjmp only in cpu-exec.c

2016-03-01 Thread Peter Maydell
On 1 March 2016 at 17:53, Paolo Bonzini wrote: > > > On 01/03/2016 18:46, Andrew Baumann wrote: >> --- a/include/sysemu/os-win32.h >> +++ b/include/sysemu/os-win32.h >> @@ -60,6 +60,7 @@ >> * If this parameter is NULL, longjump does no stack unwinding. >> * That is what

Re: [Qemu-devel] [PATCH] Use special code for sigsetjmp only in cpu-exec.c

2016-03-01 Thread Paolo Bonzini
On 01/03/2016 18:46, Andrew Baumann wrote: > --- a/include/sysemu/os-win32.h > +++ b/include/sysemu/os-win32.h > @@ -60,6 +60,7 @@ > * If this parameter is NULL, longjump does no stack unwinding. > * That is what we need for QEMU. Passing the value of register rsp (default) > * lets

Re: [Qemu-devel] [PATCH] Use special code for sigsetjmp only in cpu-exec.c

2016-03-01 Thread Andrew Baumann
> From: Stefan Weil [mailto:s...@weilnetz.de] > Sent: Tuesday, 1 March 2016 5:16 AM > > Am 01.03.2016 um 13:22 schrieb Peter Maydell: > > On 1 March 2016 at 11:54, Stefan Weil wrote: > >> Am 01.03.2016 um 10:59 schrieb Peter Maydell: > >>> I don't understand this patch. Why

Re: [Qemu-devel] [PATCH] Use special code for sigsetjmp only in cpu-exec.c

2016-03-01 Thread Stefan Weil
Am 01.03.2016 um 13:22 schrieb Peter Maydell: > On 1 March 2016 at 11:54, Stefan Weil wrote: >> Am 01.03.2016 um 10:59 schrieb Peter Maydell: >>> I don't understand this patch. Why doesn't it work to have >>> sigsetjmp() be implemented the same way for every use that >>> QEMU

Re: [Qemu-devel] [PATCH] Use special code for sigsetjmp only in cpu-exec.c

2016-03-01 Thread Peter Maydell
On 1 March 2016 at 11:54, Stefan Weil wrote: > Am 01.03.2016 um 10:59 schrieb Peter Maydell: >> I don't understand this patch. Why doesn't it work to have >> sigsetjmp() be implemented the same way for every use that >> QEMU makes of it? > It does, as long as the "same way" is

Re: [Qemu-devel] [PATCH] Use special code for sigsetjmp only in cpu-exec.c

2016-03-01 Thread Stefan Weil
Am 01.03.2016 um 10:59 schrieb Peter Maydell: > On 1 March 2016 at 05:07, Stefan Weil wrote: >> The rest of the code can use longjmp with stack unwinding. >> >> Signed-off-by: Stefan Weil >> --- >> >> This is a bug fix needed for 64 bit Windows. >> >> QEMU for

Re: [Qemu-devel] [PATCH] Use special code for sigsetjmp only in cpu-exec.c

2016-03-01 Thread Peter Maydell
On 1 March 2016 at 05:07, Stefan Weil wrote: > The rest of the code can use longjmp with stack unwinding. > > Signed-off-by: Stefan Weil > --- > > This is a bug fix needed for 64 bit Windows. > > QEMU for Windows currently gets the wrong definition for >

Re: [Qemu-devel] [PATCH] Use special code for sigsetjmp only in cpu-exec.c

2016-02-29 Thread Andrew Baumann
> From: Stefan Weil [mailto:s...@weilnetz.de] > Sent: Monday, 29 February 2016 9:08 PM > > The rest of the code can use longjmp with stack unwinding. > > Signed-off-by: Stefan Weil > --- > > This is a bug fix needed for 64 bit Windows. > > QEMU for Windows currently gets the

[Qemu-devel] [PATCH] Use special code for sigsetjmp only in cpu-exec.c

2016-02-29 Thread Stefan Weil
The rest of the code can use longjmp with stack unwinding. Signed-off-by: Stefan Weil --- This is a bug fix needed for 64 bit Windows. QEMU for Windows currently gets the wrong definition for sigsetjmp. It uses stack unwinding for longjmp which results in a crash when it is