Re: [Qemu-devel] [PATCH] audio: make audio poll timer deterministic

2017-02-14 Thread Paolo Bonzini
On 13/02/2017 19:40, Yurii Zubrytskyi wrote: > Hi, > > It looks to me that this behavior can be achieved with > "timer_mod_anticipate()" function instead of a separate check. True, but I think Pavel's version is more readable. Since the timer is set to a fixed value from QEMU_CLOCK_VIRTUAL, ti

Re: [Qemu-devel] [PATCH] audio: make audio poll timer deterministic

2017-02-13 Thread Yurii Zubrytskyi
Hi, It looks to me that this behavior can be achieved with "timer_mod_anticipate()" function instead of a separate check. On Sun, Feb 12, 2017 at 9:04 PM, Pavel Dovgalyuk wrote: > Ping? > > Pavel Dovgalyuk > > > > -Original Message- > > From: Pavel Dovgalyuk [mailto:pavel.dovga...@ispra

Re: [Qemu-devel] [PATCH] audio: make audio poll timer deterministic

2017-02-12 Thread Pavel Dovgalyuk
Ping? Pavel Dovgalyuk > -Original Message- > From: Pavel Dovgalyuk [mailto:pavel.dovga...@ispras.ru] > Sent: Tuesday, January 31, 2017 2:59 PM > To: qemu-devel@nongnu.org > Cc: pbonz...@redhat.com; dovga...@ispras.ru; kra...@redhat.com > Subject: [PATCH] audio: make audio poll timer dete

Re: [Qemu-devel] [PATCH] audio: make audio poll timer deterministic

2017-02-01 Thread Gerd Hoffmann
On Di, 2017-01-31 at 15:32 +0300, Pavel Dovgalyuk wrote: > This patch is needed to make this timer deterministic and to use > execution record/replay > > for audio devices. > > > > audio_reset_timer is used in the function > audio_vm_change_state_handler. > > Therefore every time VM is stoppe

Re: [Qemu-devel] [PATCH] audio: make audio poll timer deterministic

2017-01-31 Thread Pavel Dovgalyuk
; dovga...@ispras.ru; kra...@redhat.com Subject: Re: [Qemu-devel] [PATCH] audio: make audio poll timer deterministic Hi On Tue, Jan 31, 2017 at 4:03 PM Pavel Dovgalyuk wrote: This patch changes resetting strategy of the audio polling timer. It does not change expiration time if the timer is

Re: [Qemu-devel] [PATCH] audio: make audio poll timer deterministic

2017-01-31 Thread Marc-André Lureau
Hi On Tue, Jan 31, 2017 at 4:03 PM Pavel Dovgalyuk wrote: > This patch changes resetting strategy of the audio polling timer. > It does not change expiration time if the timer is already set. > > You describe the change, but could you explain the reasons you propose it? > Signed-off-by: Pavel

Re: [Qemu-devel] [PATCH] audio: make audio poll timer deterministic

2017-01-31 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [PATCH] audio: make audio poll timer deterministic Message-id: 20170131115913.6828.12266.stgit@PASHA-ISP === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total

[Qemu-devel] [PATCH] audio: make audio poll timer deterministic

2017-01-31 Thread Pavel Dovgalyuk
This patch changes resetting strategy of the audio polling timer. It does not change expiration time if the timer is already set. Signed-off-by: Pavel Dovgalyuk --- audio/audio.c |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/audio/audio.c b/audio/audio.c index c845