Re: [Qemu-devel] [PATCH] bios-tables-test: delete a assert about block name

2017-08-14 Thread Michael S. Tsirkin
On Tue, Aug 15, 2017 at 11:53:29AM +0800, wyang wrote: > Seems the only place, which needs to be fixed, is to replace sizeof with > strlen. Just like what you said, it is not fault but just refinement. > If you need it, I am glad to send patch to fix it. > > Wei Sure. > -- > Wei Yang(杨伟) > Mob

Re: [Qemu-devel] [PATCH] bios-tables-test: delete a assert about block name

2017-08-14 Thread wyang
On 2017年08月15日 10:49, Michael S. Tsirkin wrote: BTW sizeof(BLOCK_NAME_END) is actually 2. I think it works because there's a space after ,. It is better to replace it with strlen so it will work without a space too. MST, I double check the failure of assert, it has already been fixed by the

Re: [Qemu-devel] [PATCH] bios-tables-test: delete a assert about block name

2017-08-14 Thread wyang
On 2017年08月14日 23:58, Michael S. Tsirkin wrote: On Mon, Aug 14, 2017 at 04:48:38PM +0800, wei.y...@ucloud.cn wrote: From: Wei Yang The assert would be touched when the version of acpica is greater than or equal to 20160318. its reason is that "Disasembler: Update a couple output items(commit i

Re: [Qemu-devel] [PATCH] bios-tables-test: delete a assert about block name

2017-08-14 Thread Michael S. Tsirkin
On Tue, Aug 15, 2017 at 10:46:27AM +0800, wyang wrote: > > > On 2017年08月15日 10:39, Michael S. Tsirkin wrote: > > On Tue, Aug 15, 2017 at 10:21:08AM +0800, wyang wrote: > > > On 2017年08月14日 23:58, Michael S. Tsirkin wrote: > > > > On Mon, Aug 14, 2017 at 04:48:38PM +0800, wei.y...@ucloud.cn wrote:

Re: [Qemu-devel] [PATCH] bios-tables-test: delete a assert about block name

2017-08-14 Thread wyang
On 2017年08月15日 10:39, Michael S. Tsirkin wrote: On Tue, Aug 15, 2017 at 10:21:08AM +0800, wyang wrote: On 2017年08月14日 23:58, Michael S. Tsirkin wrote: On Mon, Aug 14, 2017 at 04:48:38PM +0800, wei.y...@ucloud.cn wrote: From: Wei Yang The assert would be touched when the version of acpica i

Re: [Qemu-devel] [PATCH] bios-tables-test: delete a assert about block name

2017-08-14 Thread Michael S. Tsirkin
On Tue, Aug 15, 2017 at 10:21:08AM +0800, wyang wrote: > On 2017年08月14日 23:58, Michael S. Tsirkin wrote: > > On Mon, Aug 14, 2017 at 04:48:38PM +0800, wei.y...@ucloud.cn wrote: > > > From: Wei Yang > > > > > > The assert would be touched when the version of acpica is greater than or > > > equal t

Re: [Qemu-devel] [PATCH] bios-tables-test: delete a assert about block name

2017-08-14 Thread Michael S. Tsirkin
On Mon, Aug 14, 2017 at 04:48:38PM +0800, wei.y...@ucloud.cn wrote: > From: Wei Yang > > The assert would be touched when the version of acpica is greater than or > equal to 20160318. its reason is that "Disasembler: Update a couple > output items(commit id: 1ecbb3d)" is introduced by Robert, the

[Qemu-devel] [PATCH] bios-tables-test: delete a assert about block name

2017-08-14 Thread wei . yang
From: Wei Yang The assert would be touched when the version of acpica is greater than or equal to 20160318. its reason is that "Disasembler: Update a couple output items(commit id: 1ecbb3d)" is introduced by Robert, the patch emits the AML filename as a zero-length string, and allows the compiler