Re: [Qemu-devel] [PATCH] block/sheepdog: add error handling to sd_snapshot_delete()

Thank you for your review, Jeff! I'll submit a patch v2 soon. In addition, I found that we also need to set errp below. This will be fixed in v2, too. | 2607switch (rsp->result) { | 2608case SD_RES_NO_VDI: | 2609error_report("%s was already deleted", s->name); Takashi >

Re: [Qemu-devel] [PATCH] block/sheepdog: add error handling to sd_snapshot_delete()

On Fri, Mar 18, 2016 at 05:54:38PM +0900, Takashi Menjo wrote: > Errors have been ignored in some code paths in sd_snapshot_delete(). > This patch adds error handling. > > Signed-off-by: Takashi Menjo Thank you for the patch! > --- > block/sheepdog.c | 3 +++ > 1

[Qemu-devel] [PATCH] block/sheepdog: add error handling to sd_snapshot_delete()

Errors have been ignored in some code paths in sd_snapshot_delete(). This patch adds error handling. Signed-off-by: Takashi Menjo --- block/sheepdog.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/block/sheepdog.c b/block/sheepdog.c index a3aeae4..6492405