See my comments below, updated patch will follow later:
On Tue, Oct 12, 2010 at 3:57 PM, Anthony Liguori anth...@codemonkey.ws wrote:
...
+
+static int rbd_parsename(const char *filename, char *pool, char **snap,
+ char *name)
+{
+ const char *rbdname;
+ char
See my comments:
On Wed, Oct 13, 2010 at 1:41 AM, Stefan Hajnoczi stefa...@gmail.com wrote:
+
+ cpu_to_le32s(snap_count);
+ cpu_to_le64s(snap_names_len);
Redone all endianity conversions, made it so that it keeps the header
as little endian, and whenever reading the header, do the
On Wed, Oct 13, 2010 at 12:18 AM, Christian Brunner c...@muc.de wrote:
+static int rbd_set_snapc(rados_pool_t pool, const char *snap, RbdHeader1
*header)
+{
+ uint32_t snap_count = header-snap_count;
+ rados_snap_t *snaps = NULL;
+ rados_snap_t seq;
+ uint32_t i;
+ uint64_t
Hi Anthony,
Hi Kevin,
Hi Stefan,
here is an updated version of the ceph/rbd block driver. It includes all
the changes Yehuda made after the discussion on the list last weekend.
As far as I can tell all the issues discussed are fixed.
Please let us know if the driver is ready for inclusion now.
On 10/12/2010 06:18 PM, Christian Brunner wrote:
Hi Anthony,
Hi Kevin,
Hi Stefan,
here is an updated version of the ceph/rbd block driver. It includes all
the changes Yehuda made after the discussion on the list last weekend.
As far as I can tell all the issues discussed are fixed.
Please let
