Re: [Qemu-devel] [PATCH] cli: Don't run early event loop if no --preconfig was specified

2018-06-05 Thread Igor Mammedov
On Tue, 5 Jun 2018 13:43:14 +0200 Igor Mammedov wrote: > On Mon, 4 Jun 2018 21:41:46 -0300 > Eduardo Habkost wrote: > > > On Mon, Jun 04, 2018 at 11:32:44AM +0100, Daniel P. Berrangé wrote: > > [...] > > > Avoiding the double-run of main_loop is good, however, I think we should > > > also

Re: [Qemu-devel] [PATCH] cli: Don't run early event loop if no --preconfig was specified

2018-06-05 Thread Igor Mammedov
On Mon, 4 Jun 2018 21:41:46 -0300 Eduardo Habkost wrote: > On Mon, Jun 04, 2018 at 11:32:44AM +0100, Daniel P. Berrangé wrote: > [...] > > Avoiding the double-run of main_loop is good, however, I think we should > > also not have put current_run_state in RUN_STATE_PRECONFIG in the first > >

Re: [Qemu-devel] [PATCH] cli: Don't run early event loop if no --preconfig was specified

2018-06-04 Thread Eduardo Habkost
On Mon, Jun 04, 2018 at 11:32:44AM +0100, Daniel P. Berrangé wrote: [...] > Avoiding the double-run of main_loop is good, however, I think we should > also not have put current_run_state in RUN_STATE_PRECONFIG in the first > place if --preconfig wasn't set. I've sent a patch to fix that problem >

Re: [Qemu-devel] [PATCH] cli: Don't run early event loop if no --preconfig was specified

2018-06-04 Thread Igor Mammedov
On Sat, 2 Jun 2018 12:34:52 +0200 Michal Privoznik wrote: > After 047f7038f586d215 it is possible for event loop to run two > times. First time whilst parsing command line options (the idea > is to bring up monitor early so that management applications can > tweak config before machine is

Re: [Qemu-devel] [PATCH] cli: Don't run early event loop if no --preconfig was specified

2018-06-04 Thread Daniel P . Berrangé
On Sat, Jun 02, 2018 at 12:34:52PM +0200, Michal Privoznik wrote: > After 047f7038f586d215 it is possible for event loop to run two > times. First time whilst parsing command line options (the idea > is to bring up monitor early so that management applications can > tweak config before machine is

[Qemu-devel] [PATCH] cli: Don't run early event loop if no --preconfig was specified

2018-06-02 Thread Michal Privoznik
After 047f7038f586d215 it is possible for event loop to run two times. First time whilst parsing command line options (the idea is to bring up monitor early so that management applications can tweak config before machine is initialized). And the second time is after everything is set up (this is