Re: [Qemu-devel] [PATCH] hmp: fix "dump-quest-memory" segfault (ppc)

2017-09-11 Thread Thomas Huth
On 12.09.2017 06:52, Miroslav Rezanina wrote: > > > - Original Message - >> From: "Thomas Huth" >> To: "Laurent Vivier" , qemu-devel@nongnu.org >> Cc: "David Gibson" , qemu-...@nongnu.org, "Dr . >> David Alan Gilbert"

Re: [Qemu-devel] [PATCH] hmp: fix "dump-quest-memory" segfault (ppc)

2017-09-11 Thread Miroslav Rezanina
- Original Message - > From: "Thomas Huth" > To: "Laurent Vivier" , qemu-devel@nongnu.org > Cc: "David Gibson" , qemu-...@nongnu.org, "Dr . > David Alan Gilbert" > , "Miroslav Rezanina"

Re: [Qemu-devel] [PATCH] hmp: fix "dump-quest-memory" segfault (ppc)

2017-09-11 Thread Thomas Huth
On 11.09.2017 14:15, Laurent Vivier wrote: > On 11/09/2017 14:13, Daniel P. Berrange wrote: >> On Mon, Sep 11, 2017 at 02:10:14PM +0200, Laurent Vivier wrote: >>> On 11/09/2017 14:04, Dr. David Alan Gilbert wrote: * Daniel P. Berrange (berra...@redhat.com) wrote: > On Mon, Sep 11, 2017 at

Re: [Qemu-devel] [PATCH] hmp: fix "dump-quest-memory" segfault (ppc)

2017-09-11 Thread Thomas Huth
On 11.09.2017 13:00, Laurent Vivier wrote: > Commit fd5d23babf (hmp: fix "dump-quest-memory" segfault) > fixes the problem for i386, do the same for ppc. > > Running QEMU with > qemu-system-ppc64 -M none -nographic -m 256 > and executing > dump-guest-memory /dev/null 0 8192 > results in

Re: [Qemu-devel] [PATCH] hmp: fix "dump-quest-memory" segfault (ppc)

2017-09-11 Thread Laurent Vivier
On 11/09/2017 13:41, Cornelia Huck wrote: > On Mon, 11 Sep 2017 12:06:15 +0100 > "Daniel P. Berrange" wrote: > >> On Mon, Sep 11, 2017 at 01:00:37PM +0200, Laurent Vivier wrote: >>> Commit fd5d23babf (hmp: fix "dump-quest-memory" segfault) >>> fixes the problem for i386, do

Re: [Qemu-devel] [PATCH] hmp: fix "dump-quest-memory" segfault (ppc)

2017-09-11 Thread Cornelia Huck
On Mon, 11 Sep 2017 14:10:14 +0200 Laurent Vivier wrote: > On 11/09/2017 14:04, Dr. David Alan Gilbert wrote: > > * Daniel P. Berrange (berra...@redhat.com) wrote: > >> On Mon, Sep 11, 2017 at 01:41:58PM +0200, Cornelia Huck wrote: > >>> However, if we start a qemu with

Re: [Qemu-devel] [PATCH] hmp: fix "dump-quest-memory" segfault (ppc)

2017-09-11 Thread Laurent Vivier
On 11/09/2017 14:13, Daniel P. Berrange wrote: > On Mon, Sep 11, 2017 at 02:10:14PM +0200, Laurent Vivier wrote: >> On 11/09/2017 14:04, Dr. David Alan Gilbert wrote: >>> * Daniel P. Berrange (berra...@redhat.com) wrote: On Mon, Sep 11, 2017 at 01:41:58PM +0200, Cornelia Huck wrote: > On

Re: [Qemu-devel] [PATCH] hmp: fix "dump-quest-memory" segfault (ppc)

2017-09-11 Thread Daniel P. Berrange
On Mon, Sep 11, 2017 at 02:10:14PM +0200, Laurent Vivier wrote: > On 11/09/2017 14:04, Dr. David Alan Gilbert wrote: > > * Daniel P. Berrange (berra...@redhat.com) wrote: > >> On Mon, Sep 11, 2017 at 01:41:58PM +0200, Cornelia Huck wrote: > >>> On Mon, 11 Sep 2017 12:06:15 +0100 > >>> "Daniel P.

Re: [Qemu-devel] [PATCH] hmp: fix "dump-quest-memory" segfault (ppc)

2017-09-11 Thread Laurent Vivier
On 11/09/2017 14:04, Dr. David Alan Gilbert wrote: > * Daniel P. Berrange (berra...@redhat.com) wrote: >> On Mon, Sep 11, 2017 at 01:41:58PM +0200, Cornelia Huck wrote: >>> On Mon, 11 Sep 2017 12:06:15 +0100 >>> "Daniel P. Berrange" wrote: >>> On Mon, Sep 11, 2017 at

Re: [Qemu-devel] [PATCH] hmp: fix "dump-quest-memory" segfault (ppc)

2017-09-11 Thread Dr. David Alan Gilbert
* Daniel P. Berrange (berra...@redhat.com) wrote: > On Mon, Sep 11, 2017 at 01:41:58PM +0200, Cornelia Huck wrote: > > On Mon, 11 Sep 2017 12:06:15 +0100 > > "Daniel P. Berrange" wrote: > > > > > On Mon, Sep 11, 2017 at 01:00:37PM +0200, Laurent Vivier wrote: > > > > Commit

Re: [Qemu-devel] [PATCH] hmp: fix "dump-quest-memory" segfault (ppc)

2017-09-11 Thread Daniel P. Berrange
On Mon, Sep 11, 2017 at 01:41:58PM +0200, Cornelia Huck wrote: > On Mon, 11 Sep 2017 12:06:15 +0100 > "Daniel P. Berrange" wrote: > > > On Mon, Sep 11, 2017 at 01:00:37PM +0200, Laurent Vivier wrote: > > > Commit fd5d23babf (hmp: fix "dump-quest-memory" segfault) > > > fixes

Re: [Qemu-devel] [PATCH] hmp: fix "dump-quest-memory" segfault (ppc)

2017-09-11 Thread Cornelia Huck
On Mon, 11 Sep 2017 12:06:15 +0100 "Daniel P. Berrange" wrote: > On Mon, Sep 11, 2017 at 01:00:37PM +0200, Laurent Vivier wrote: > > Commit fd5d23babf (hmp: fix "dump-quest-memory" segfault) > > fixes the problem for i386, do the same for ppc. > > What about all the other

Re: [Qemu-devel] [PATCH] hmp: fix "dump-quest-memory" segfault (ppc)

2017-09-11 Thread Laurent Vivier
On 11/09/2017 13:06, Daniel P. Berrange wrote: > On Mon, Sep 11, 2017 at 01:00:37PM +0200, Laurent Vivier wrote: >> Commit fd5d23babf (hmp: fix "dump-quest-memory" segfault) >> fixes the problem for i386, do the same for ppc. > > What about all the other targets QEMU supports ? Have you checked

Re: [Qemu-devel] [PATCH] hmp: fix "dump-quest-memory" segfault (ppc)

2017-09-11 Thread Daniel P. Berrange
On Mon, Sep 11, 2017 at 01:00:37PM +0200, Laurent Vivier wrote: > Commit fd5d23babf (hmp: fix "dump-quest-memory" segfault) > fixes the problem for i386, do the same for ppc. What about all the other targets QEMU supports ? Have you checked if they are similarly affected, as we don't want to

[Qemu-devel] [PATCH] hmp: fix "dump-quest-memory" segfault (ppc)

2017-09-11 Thread Laurent Vivier
Commit fd5d23babf (hmp: fix "dump-quest-memory" segfault) fixes the problem for i386, do the same for ppc. Running QEMU with qemu-system-ppc64 -M none -nographic -m 256 and executing dump-guest-memory /dev/null 0 8192 results in segfault Fix by checking if we have CPU. Signed-off-by: