Re: [Qemu-devel] [PATCH] hw/misc/auxbus.c: Mark the aux-to-i2c-bridge device as non-hotpluggable

2017-08-23 Thread KONRAD Frederic
On 08/23/2017 07:22 AM, Thomas Huth wrote: On 22.08.2017 20:15, KONRAD Frederic wrote: Hi Thomas, Looking to this seems there is a second issue: The aux-to-i2c-bridge device should connect on a TYPE_AUX_BUS. I don't think there isn't any on integratorcp.. Anyway the patch you sent fix this

Re: [Qemu-devel] [PATCH] hw/misc/auxbus.c: Mark the aux-to-i2c-bridge device as non-hotpluggable

2017-08-22 Thread Thomas Huth
On 22.08.2017 20:15, KONRAD Frederic wrote: > Hi Thomas, > > Looking to this seems there is a second issue: > The aux-to-i2c-bridge device should connect on a TYPE_AUX_BUS. > > I don't think there isn't any on integratorcp.. > > Anyway the patch you sent fix this issue indirectly and as far as

Re: [Qemu-devel] [PATCH] hw/misc/auxbus.c: Mark the aux-to-i2c-bridge device as non-hotpluggable

2017-08-22 Thread KONRAD Frederic
Hi Thomas, Looking to this seems there is a second issue: The aux-to-i2c-bridge device should connect on a TYPE_AUX_BUS. I don't think there isn't any on integratorcp.. Anyway the patch you sent fix this issue indirectly and as far as I remember I wasn't able to make this I2C bridge an

Re: [Qemu-devel] [PATCH] hw/misc/auxbus.c: Mark the aux-to-i2c-bridge device as non-hotpluggable

2017-08-22 Thread Peter Maydell
On 22 August 2017 at 16:06, Thomas Huth wrote: > QEMU currently aborts if the user tries to do something like this: > > $ aarch64-softmmu/qemu-system-aarch64 -S -M integratorcp -nographic > QEMU 2.9.93 monitor - type 'help' for more information > (qemu) device_add

Re: [Qemu-devel] [PATCH] hw/misc/auxbus.c: Mark the aux-to-i2c-bridge device as non-hotpluggable

2017-08-22 Thread Peter Maydell
On 22 August 2017 at 16:26, Thomas Huth wrote: > On 22.08.2017 17:12, Peter Maydell wrote: >> Why is our default "hotpluggable" rather than "not hotpluggable" ? >> We must have way more non-hotpluggable devices than hotpluggable >> ones, and it takes active effort to make a

Re: [Qemu-devel] [PATCH] hw/misc/auxbus.c: Mark the aux-to-i2c-bridge device as non-hotpluggable

2017-08-22 Thread Thomas Huth
On 22.08.2017 17:30, Peter Maydell wrote: > On 22 August 2017 at 16:26, Thomas Huth wrote: >> On 22.08.2017 17:12, Peter Maydell wrote: >>> Why is our default "hotpluggable" rather than "not hotpluggable" ? >>> We must have way more non-hotpluggable devices than hotpluggable >>>

Re: [Qemu-devel] [PATCH] hw/misc/auxbus.c: Mark the aux-to-i2c-bridge device as non-hotpluggable

2017-08-22 Thread Thomas Huth
On 22.08.2017 17:12, Peter Maydell wrote: > On 22 August 2017 at 16:06, Thomas Huth wrote: >> QEMU currently aborts if the user tries to do something like this: >> >> $ aarch64-softmmu/qemu-system-aarch64 -S -M integratorcp -nographic >> QEMU 2.9.93 monitor - type 'help' for

[Qemu-devel] [PATCH] hw/misc/auxbus.c: Mark the aux-to-i2c-bridge device as non-hotpluggable

2017-08-22 Thread Thomas Huth
QEMU currently aborts if the user tries to do something like this: $ aarch64-softmmu/qemu-system-aarch64 -S -M integratorcp -nographic QEMU 2.9.93 monitor - type 'help' for more information (qemu) device_add aux-to-i2c-bridge,id=x (qemu) device_del x ** ERROR:qemu/qdev-monitor.c:872:qdev_unplug: