Re: [Qemu-devel] [PATCH] hw/virtio-serial-bus: post_load send_event when vm is running

2012-11-19 Thread Paolo Bonzini
Il 18/11/2012 20:17, Blue Swirl ha scritto: +struct { Please add a name, for example PostLoad. Why? This is not C++ and the namespace would be global. It's just to have a nice grouping. Otherwise the structure will be anonymous and those were only added to C11, not C99. No,

Re: [Qemu-devel] [PATCH] hw/virtio-serial-bus: post_load send_event when vm is running

2012-11-18 Thread Paolo Bonzini
struct virtio_console_config config; + +struct { Please add a name, for example PostLoad. Why? This is not C++ and the namespace would be global. It's just to have a nice grouping. Paolo +QEMUTimer *timer; +int nr_active_ports; +struct { +

Re: [Qemu-devel] [PATCH] hw/virtio-serial-bus: post_load send_event when vm is running

2012-11-18 Thread Blue Swirl
On Sun, Nov 18, 2012 at 4:29 PM, Paolo Bonzini pbonz...@redhat.com wrote: struct virtio_console_config config; + +struct { Please add a name, for example PostLoad. Why? This is not C++ and the namespace would be global. It's just to have a nice grouping. Otherwise the

Re: [Qemu-devel] [PATCH] hw/virtio-serial-bus: post_load send_event when vm is running

2012-11-17 Thread Blue Swirl
On Wed, Nov 14, 2012 at 1:09 PM, Alon Levy al...@redhat.com wrote: Add a new timer based on vm_clock for 1 ns in the future from post_load to do the event send in case host_connected differs between migration source and target. RHBZ: 867366 Signed-off-by: Alon Levy al...@redhat.com ---

Re: [Qemu-devel] [PATCH] hw/virtio-serial-bus: post_load send_event when vm is running

2012-11-16 Thread Amit Shah
On (Wed) 14 Nov 2012 [15:09:07], Alon Levy wrote: Add a new timer based on vm_clock for 1 ns in the future from post_load to do the event send in case host_connected differs between migration source and target. RHBZ: 867366 Signed-off-by: Alon Levy al...@redhat.com ---

[Qemu-devel] [PATCH] hw/virtio-serial-bus: post_load send_event when vm is running

2012-11-14 Thread Alon Levy
Add a new timer based on vm_clock for 1 ns in the future from post_load to do the event send in case host_connected differs between migration source and target. RHBZ: 867366 Signed-off-by: Alon Levy al...@redhat.com --- hw/virtio-serial-bus.c | 54

Re: [Qemu-devel] [PATCH] hw/virtio-serial-bus: post_load send_event when vm is running

2012-11-14 Thread Paolo Bonzini
Il 14/11/2012 14:09, Alon Levy ha scritto: Add a new timer based on vm_clock for 1 ns in the future from post_load to do the event send in case host_connected differs between migration source and target. RHBZ: 867366 Signed-off-by: Alon Levy al...@redhat.com --- hw/virtio-serial-bus.c