Re: [Qemu-devel] [PATCH] iothread: fix crash with invalid properties

2018-09-26 Thread Fam Zheng
On Wed, 09/26 12:33, Marc-André Lureau wrote: > Hi > > On Wed, Sep 26, 2018 at 12:13 PM Fam Zheng wrote: > > > > On Tue, 08/21 12:07, Marc-André Lureau wrote: > > > -object iothread,id=foo,? will crash qemu: > > > > > > qemu-system-x86_64:qemu-thread-posix.c:128: qemu_cond_destroy: Assertion >

Re: [Qemu-devel] [PATCH] iothread: fix crash with invalid properties

2018-09-26 Thread Marc-André Lureau
Hi On Wed, Sep 26, 2018 at 12:13 PM Fam Zheng wrote: > > On Tue, 08/21 12:07, Marc-André Lureau wrote: > > -object iothread,id=foo,? will crash qemu: > > > > qemu-system-x86_64:qemu-thread-posix.c:128: qemu_cond_destroy: Assertion > > `cond->initialized' failed. > > > > Use thread_id != -1 to

Re: [Qemu-devel] [PATCH] iothread: fix crash with invalid properties

2018-09-26 Thread Fam Zheng
On Tue, 08/21 12:07, Marc-André Lureau wrote: > -object iothread,id=foo,? will crash qemu: > > qemu-system-x86_64:qemu-thread-posix.c:128: qemu_cond_destroy: Assertion > `cond->initialized' failed. > > Use thread_id != -1 to check if iothread_complete() finished > successfully and the

Re: [Qemu-devel] [PATCH] iothread: fix crash with invalid properties

2018-08-28 Thread Marc-André Lureau
ping On Tue, Aug 21, 2018 at 12:07 PM Marc-André Lureau wrote: > > -object iothread,id=foo,? will crash qemu: > > qemu-system-x86_64:qemu-thread-posix.c:128: qemu_cond_destroy: Assertion > `cond->initialized' failed. > > Use thread_id != -1 to check if iothread_complete() finished > successfully

[Qemu-devel] [PATCH] iothread: fix crash with invalid properties

2018-08-21 Thread Marc-André Lureau
-object iothread,id=foo,? will crash qemu: qemu-system-x86_64:qemu-thread-posix.c:128: qemu_cond_destroy: Assertion `cond->initialized' failed. Use thread_id != -1 to check if iothread_complete() finished successfully and the mutex/cond have been initialized. Signed-off-by: Marc-André Lureau