Re: [Qemu-devel] [PATCH] kvmvapic: align start address as well as size

2012-03-15 Thread Avi Kivity
On 03/14/2012 10:33 PM, Anthony Liguori wrote: On 03/06/2012 09:50 AM, Avi Kivity wrote: The kvmvapic code remaps a section of ROM as RAM to allow the guest to maintain state there. It is careful to align the section size to a page boundary, to avoid creating subpages, but neglects to do the

Re: [Qemu-devel] [PATCH] kvmvapic: align start address as well as size

2012-03-15 Thread Anthony Liguori
On 03/15/2012 04:55 AM, Avi Kivity wrote: On 03/14/2012 10:33 PM, Anthony Liguori wrote: On 03/06/2012 09:50 AM, Avi Kivity wrote: The kvmvapic code remaps a section of ROM as RAM to allow the guest to maintain state there. It is careful to align the section size to a page boundary, to avoid

Re: [Qemu-devel] [PATCH] kvmvapic: align start address as well as size

2012-03-14 Thread Anthony Liguori
On 03/06/2012 09:50 AM, Avi Kivity wrote: The kvmvapic code remaps a section of ROM as RAM to allow the guest to maintain state there. It is careful to align the section size to a page boundary, to avoid creating subpages, but neglects to do the same for the start address. These leads to an

Re: [Qemu-devel] [PATCH] kvmvapic: align start address as well as size

2012-03-14 Thread Anthony Liguori
On 03/06/2012 09:50 AM, Avi Kivity wrote: The kvmvapic code remaps a section of ROM as RAM to allow the guest to maintain state there. It is careful to align the section size to a page boundary, to avoid creating subpages, but neglects to do the same for the start address. These leads to an

[Qemu-devel] [PATCH] kvmvapic: align start address as well as size

2012-03-06 Thread Avi Kivity
The kvmvapic code remaps a section of ROM as RAM to allow the guest to maintain state there. It is careful to align the section size to a page boundary, to avoid creating subpages, but neglects to do the same for the start address. These leads to an assert later on when the memory core tries to

Re: [Qemu-devel] [PATCH] kvmvapic: align start address as well as size

2012-03-06 Thread Jan Kiszka
On 2012-03-06 16:50, Avi Kivity wrote: The kvmvapic code remaps a section of ROM as RAM to allow the guest to maintain state there. It is careful to align the section size to a page boundary, to avoid creating subpages, but neglects to do the same for the start address. These leads to an