Re: [Qemu-devel] [PATCH] megasas: Update function megasys_scsi_uninit

2012-08-01 Thread Paolo Bonzini
Il 01/08/2012 00:17, Hannes Reinecke ha scritto: Ad 2: no, the SAS address for the devices is _not_ the WWN. The WWN is the ID of the LUN, whereas the SAS address is the ID of the Target. So to be correct we would need to generate unique SAS addressed per target which needs to be different

Re: [Qemu-devel] [PATCH] megasas: Update function megasys_scsi_uninit

2012-08-01 Thread Hannes Reinecke
On 08/01/2012 09:38 AM, Paolo Bonzini wrote: Il 01/08/2012 00:17, Hannes Reinecke ha scritto: Ad 2: no, the SAS address for the devices is _not_ the WWN. The WWN is the ID of the LUN, whereas the SAS address is the ID of the Target. So to be correct we would need to generate unique SAS

Re: [Qemu-devel] [PATCH] megasas: Update function megasys_scsi_uninit

2012-08-01 Thread Paolo Bonzini
Il 01/08/2012 09:54, Hannes Reinecke ha scritto: On 08/01/2012 09:38 AM, Paolo Bonzini wrote: Il 01/08/2012 00:17, Hannes Reinecke ha scritto: Ad 2: no, the SAS address for the devices is _not_ the WWN. The WWN is the ID of the LUN, whereas the SAS address is the ID of the Target. So to be

Re: [Qemu-devel] [PATCH] megasas: Update function megasys_scsi_uninit

2012-08-01 Thread Hannes Reinecke
On 08/01/2012 10:01 AM, Paolo Bonzini wrote: Il 01/08/2012 09:54, Hannes Reinecke ha scritto: On 08/01/2012 09:38 AM, Paolo Bonzini wrote: Il 01/08/2012 00:17, Hannes Reinecke ha scritto: Ad 2: no, the SAS address for the devices is _not_ the WWN. The WWN is the ID of the LUN, whereas the SAS

Re: [Qemu-devel] [PATCH] megasas: Update function megasys_scsi_uninit

2012-07-31 Thread Paolo Bonzini
Il 31/07/2012 07:54, Stefan Weil ha scritto: Commit f90c2bcdbc69e41e575f868b984c3e2de8f51bac changed PCIUnregisterFunc, therefore the function prototype needs an update. megasas.o is currently not linked, so this bug was not detected by the buildbots. Signed-off-by: Stefan Weil

Re: [Qemu-devel] [PATCH] megasas: Update function megasys_scsi_uninit

2012-07-31 Thread Andreas Färber
Am 31.07.2012 07:54, schrieb Stefan Weil: Commit f90c2bcdbc69e41e575f868b984c3e2de8f51bac changed PCIUnregisterFunc, therefore the function prototype needs an update. megasas.o is currently not linked, so this bug was not detected by the buildbots. Why would megasas be in master but not

Re: [Qemu-devel] [PATCH] megasas: Update function megasys_scsi_uninit

2012-07-31 Thread Paolo Bonzini
Il 31/07/2012 16:39, Andreas Färber ha scritto: Commit f90c2bcdbc69e41e575f868b984c3e2de8f51bac changed PCIUnregisterFunc, therefore the function prototype needs an update. megasas.o is currently not linked, so this bug was not detected by the buildbots. Why would megasas be in

Re: [Qemu-devel] [PATCH] megasas: Update function megasys_scsi_uninit

2012-07-31 Thread Andreas Färber
Am 31.07.2012 16:43, schrieb Paolo Bonzini: Il 31/07/2012 16:39, Andreas Färber ha scritto: Commit f90c2bcdbc69e41e575f868b984c3e2de8f51bac changed PCIUnregisterFunc, therefore the function prototype needs an update. megasas.o is currently not linked, so this bug was not detected by the

Re: [Qemu-devel] [PATCH] megasas: Update function megasys_scsi_uninit

2012-07-31 Thread Paolo Bonzini
Il 31/07/2012 16:46, Andreas Färber ha scritto: Why would megasas be in master but not compiled/linked? Because Anthony objected to how it picks the initiator WWN. Ah, anything keeping us from fixing that? :) Exact knowledge of the requirements, basically. :) Paolo

Re: [Qemu-devel] [PATCH] megasas: Update function megasys_scsi_uninit

2012-07-31 Thread Andreas Färber
Am 31.07.2012 16:50, schrieb Paolo Bonzini: Il 31/07/2012 16:46, Andreas Färber ha scritto: Why would megasas be in master but not compiled/linked? Because Anthony objected to how it picks the initiator WWN. Ah, anything keeping us from fixing that? :) Exact knowledge of the requirements,

Re: [Qemu-devel] [PATCH] megasas: Update function megasys_scsi_uninit

2012-07-31 Thread Anthony Liguori
Andreas Färber afaer...@suse.de writes: Am 31.07.2012 16:50, schrieb Paolo Bonzini: Il 31/07/2012 16:46, Andreas Färber ha scritto: Why would megasas be in master but not compiled/linked? Because Anthony objected to how it picks the initiator WWN. Ah, anything keeping us from fixing that? :)

Re: [Qemu-devel] [PATCH] megasas: Update function megasys_scsi_uninit

2012-07-31 Thread Paolo Bonzini
Il 31/07/2012 16:55, Andreas Färber ha scritto: Exact knowledge of the requirements, basically. :) I.e. waiting on feedback about numeric constraints from Hannes? :) Yeah, mostly which parts are 100% necessary and which are not. Do you need absolutely a WWN for each disk? Or waiting on

Re: [Qemu-devel] [PATCH] megasas: Update function megasys_scsi_uninit

2012-07-31 Thread Paolo Bonzini
Il 31/07/2012 17:15, Anthony Liguori ha scritto: Andreas Färber afaer...@suse.de writes: Am 31.07.2012 16:50, schrieb Paolo Bonzini: Il 31/07/2012 16:46, Andreas Färber ha scritto: Why would megasas be in master but not compiled/linked? Because Anthony objected to how it picks the initiator

Re: [Qemu-devel] [PATCH] megasas: Update function megasys_scsi_uninit

2012-07-31 Thread Hannes Reinecke
On 07/31/2012 05:45 PM, Paolo Bonzini wrote: Il 31/07/2012 17:15, Anthony Liguori ha scritto: Andreas Färber afaer...@suse.de writes: Am 31.07.2012 16:50, schrieb Paolo Bonzini: Il 31/07/2012 16:46, Andreas Färber ha scritto: Why would megasas be in master but not compiled/linked? Because

[Qemu-devel] [PATCH] megasas: Update function megasys_scsi_uninit

2012-07-30 Thread Stefan Weil
Commit f90c2bcdbc69e41e575f868b984c3e2de8f51bac changed PCIUnregisterFunc, therefore the function prototype needs an update. megasas.o is currently not linked, so this bug was not detected by the buildbots. Signed-off-by: Stefan Weil s...@weilnetz.de --- hw/megasas.c |3 +-- 1 file changed,