Re: [Qemu-devel] [PATCH] pixman: remove -Wredundand-decls

2013-04-16 Thread Markus Armbruster
Gcc issue, perhaps Paolo [cc'ed] got an idea. Alexey Kardashevskiy a...@ozlabs.ru writes: On 04/16/2013 08:48 AM, Alexey Kardashevskiy wrote: On 04/16/2013 01:55 AM, Markus Armbruster wrote: Alexey Kardashevskiy a...@ozlabs.ru writes: On 04/15/2013 10:57 PM, Markus Armbruster wrote: Alexey

Re: [Qemu-devel] [PATCH] pixman: remove -Wredundand-decls

2013-04-16 Thread Markus Armbruster
Alexey Kardashevskiy a...@ozlabs.ru writes: On 04/16/2013 01:55 AM, Markus Armbruster wrote: Alexey Kardashevskiy a...@ozlabs.ru writes: On 04/15/2013 10:57 PM, Markus Armbruster wrote: Alexey Kardashevskiy a...@ozlabs.ru writes: On 04/15/2013 08:01 PM, Peter Maydell wrote: On 15 April

Re: [Qemu-devel] [PATCH] pixman: remove -Wredundand-decls

2013-04-16 Thread Paolo Bonzini
Il 16/04/2013 09:57, Markus Armbruster ha scritto: I think this is just beautiful. Fedora18, x86_64, NO cross compiler. gcc does not apply -Wredundant-decls to /usr/include/* but does it for all other headers and in the case of cross compilation I hit this case. '-Wsystem-headers' Print

Re: [Qemu-devel] [PATCH] pixman: remove -Wredundand-decls

2013-04-16 Thread Markus Armbruster
Paolo Bonzini pbonz...@redhat.com writes: [...] This workaround does NOT work if pragmas used. #pragma GCC diagnostic error -Wredundant-decls re-enables warnings as errors. The solution is to use push/pop like this: diff --git a/coroutine-ucontext.c b/coroutine-ucontext.c index

Re: [Qemu-devel] [PATCH] pixman: remove -Wredundand-decls

2013-04-16 Thread Alexey Kardashevskiy
On 04/16/2013 07:22 PM, Paolo Bonzini wrote: Il 16/04/2013 09:57, Markus Armbruster ha scritto: I think this is just beautiful. Fedora18, x86_64, NO cross compiler. gcc does not apply -Wredundant-decls to /usr/include/* but does it for all other headers and in the case of cross compilation I

Re: [Qemu-devel] [PATCH] pixman: remove -Wredundand-decls

2013-04-16 Thread Alexey Kardashevskiy
On 04/16/2013 07:00 PM, Markus Armbruster wrote: Alexey Kardashevskiy a...@ozlabs.ru writes: On 04/16/2013 01:55 AM, Markus Armbruster wrote: Alexey Kardashevskiy a...@ozlabs.ru writes: On 04/15/2013 10:57 PM, Markus Armbruster wrote: Alexey Kardashevskiy a...@ozlabs.ru writes: On

Re: [Qemu-devel] [PATCH] pixman: remove -Wredundand-decls

2013-04-16 Thread Paolo Bonzini
Il 16/04/2013 12:54, Alexey Kardashevskiy ha scritto: but you shouldn't need it. Just configure your GCC with --with-sysroot=/foo and it should just work. --sysroot helps for native compiler but does not for the cross compiler. That usually points at an incorrect configuration when you

Re: [Qemu-devel] [PATCH] pixman: remove -Wredundand-decls

2013-04-16 Thread Kevin Wolf
Am 16.04.2013 um 11:00 hat Markus Armbruster geschrieben: Alexey Kardashevskiy a...@ozlabs.ru writes: On 04/16/2013 01:55 AM, Markus Armbruster wrote: Alexey Kardashevskiy a...@ozlabs.ru writes: On 04/15/2013 10:57 PM, Markus Armbruster wrote: Alexey Kardashevskiy a...@ozlabs.ru

Re: [Qemu-devel] [PATCH] pixman: remove -Wredundand-decls

2013-04-16 Thread Markus Armbruster
Paolo Bonzini pbonz...@redhat.com writes: Il 16/04/2013 12:54, Alexey Kardashevskiy ha scritto: but you shouldn't need it. Just configure your GCC with --with-sysroot=/foo and it should just work. --sysroot helps for native compiler but does not for the cross compiler. That usually

Re: [Qemu-devel] [PATCH] pixman: remove -Wredundand-decls

2013-04-16 Thread Markus Armbruster
Kevin Wolf kw...@redhat.com writes: Am 16.04.2013 um 11:00 hat Markus Armbruster geschrieben: Alexey Kardashevskiy a...@ozlabs.ru writes: On 04/16/2013 01:55 AM, Markus Armbruster wrote: Alexey Kardashevskiy a...@ozlabs.ru writes: On 04/15/2013 10:57 PM, Markus Armbruster wrote:

Re: [Qemu-devel] [PATCH] pixman: remove -Wredundand-decls

2013-04-15 Thread Markus Armbruster
Alexey Kardashevskiy a...@ozlabs.ru writes: The assert.h header file from Fedora18 does not have #ifdef-#endif brackets around __assert function so it cannot compile with the -Wredundant-decls switch on. Some Linux distributions (such as Debian Wheezy) still do have those brackets

Re: [Qemu-devel] [PATCH] pixman: remove -Wredundand-decls

2013-04-15 Thread Alexey Kardashevskiy
On 04/15/2013 05:08 PM, Markus Armbruster wrote: Alexey Kardashevskiy a...@ozlabs.ru writes: The assert.h header file from Fedora18 does not have #ifdef-#endif brackets around __assert function so it cannot compile with the -Wredundant-decls switch on. Some Linux distributions (such as

Re: [Qemu-devel] [PATCH] pixman: remove -Wredundand-decls

2013-04-15 Thread Peter Maydell
On 15 April 2013 03:31, Alexey Kardashevskiy a...@ozlabs.ru wrote: The assert.h header file from Fedora18 does not have #ifdef-#endif brackets around __assert function so it cannot compile with the -Wredundant-decls switch on. Some Linux distributions (such as Debian Wheezy) still do have

Re: [Qemu-devel] [PATCH] pixman: remove -Wredundand-decls

2013-04-15 Thread Alexey Kardashevskiy
On 04/15/2013 05:18 PM, Peter Maydell wrote: On 15 April 2013 03:31, Alexey Kardashevskiy a...@ozlabs.ru wrote: The assert.h header file from Fedora18 does not have #ifdef-#endif brackets around __assert function so it cannot compile with the -Wredundant-decls switch on. Some Linux

Re: [Qemu-devel] [PATCH] pixman: remove -Wredundand-decls

2013-04-15 Thread Peter Maydell
On 15 April 2013 08:26, Alexey Kardashevskiy a...@ozlabs.ru wrote: On 04/15/2013 05:18 PM, Peter Maydell wrote: On 15 April 2013 03:31, Alexey Kardashevskiy a...@ozlabs.ru wrote: The assert.h header file from Fedora18 does not have #ifdef-#endif brackets around __assert function so it

Re: [Qemu-devel] [PATCH] pixman: remove -Wredundand-decls

2013-04-15 Thread Alexey Kardashevskiy
On 04/15/2013 05:30 PM, Peter Maydell wrote: On 15 April 2013 08:26, Alexey Kardashevskiy a...@ozlabs.ru wrote: On 04/15/2013 05:18 PM, Peter Maydell wrote: On 15 April 2013 03:31, Alexey Kardashevskiy a...@ozlabs.ru wrote: The assert.h header file from Fedora18 does not have #ifdef-#endif

Re: [Qemu-devel] [PATCH] pixman: remove -Wredundand-decls

2013-04-15 Thread Markus Armbruster
Alexey Kardashevskiy a...@ozlabs.ru writes: On 04/15/2013 05:08 PM, Markus Armbruster wrote: Alexey Kardashevskiy a...@ozlabs.ru writes: The assert.h header file from Fedora18 does not have #ifdef-#endif brackets around __assert function so it cannot compile with the -Wredundant-decls

Re: [Qemu-devel] [PATCH] pixman: remove -Wredundand-decls

2013-04-15 Thread Alexey Kardashevskiy
On 04/15/2013 06:23 PM, Markus Armbruster wrote: Alexey Kardashevskiy a...@ozlabs.ru writes: On 04/15/2013 05:08 PM, Markus Armbruster wrote: Alexey Kardashevskiy a...@ozlabs.ru writes: The assert.h header file from Fedora18 does not have #ifdef-#endif brackets around __assert function

Re: [Qemu-devel] [PATCH] pixman: remove -Wredundand-decls

2013-04-15 Thread Peter Maydell
On 15 April 2013 10:50, Alexey Kardashevskiy a...@ozlabs.ru wrote: /home/alexey/pcipassthru/qemu-impreza/../lib4qemu/usr/include/assert.h:67:13: error: redundant redeclaration of '__assert_fail' [-Werror=redundant-decls]

Re: [Qemu-devel] [PATCH] pixman: remove -Wredundand-decls

2013-04-15 Thread Peter Maydell
On 15 April 2013 11:01, Peter Maydell peter.mayd...@linaro.org wrote: This copy of assert.h seems to be broken. The declarations should be guarded (by _ASSERT_H_DECLS in my system's copy). FWIW, the _ASSERT_H_DECLS fix appears to be a Debian specific patch (added in 2003; I can't find any

Re: [Qemu-devel] [PATCH] pixman: remove -Wredundand-decls

2013-04-15 Thread Peter Maydell
On 15 April 2013 11:52, Alexey Kardashevskiy a...@ozlabs.ru wrote: I suspect I am getting these errors because I am the only person who is trying to cross compile or/and when host and target endianness differ. Cross compilation or otherwise should have zero effect here. You may be hitting more

Re: [Qemu-devel] [PATCH] pixman: remove -Wredundand-decls

2013-04-15 Thread Alexey Kardashevskiy
On 04/15/2013 08:01 PM, Peter Maydell wrote: On 15 April 2013 10:50, Alexey Kardashevskiy a...@ozlabs.ru wrote: /home/alexey/pcipassthru/qemu-impreza/../lib4qemu/usr/include/assert.h:67:13: error: redundant redeclaration of '__assert_fail' [-Werror=redundant-decls]

Re: [Qemu-devel] [PATCH] pixman: remove -Wredundand-decls

2013-04-15 Thread Alexey Kardashevskiy
On 04/15/2013 09:00 PM, Peter Maydell wrote: On 15 April 2013 11:52, Alexey Kardashevskiy a...@ozlabs.ru wrote: I suspect I am getting these errors because I am the only person who is trying to cross compile or/and when host and target endianness differ. Cross compilation or otherwise should

Re: [Qemu-devel] [PATCH] pixman: remove -Wredundand-decls

2013-04-15 Thread Peter Maydell
On 15 April 2013 12:08, Alexey Kardashevskiy a...@ozlabs.ru wrote: On 04/15/2013 09:00 PM, Peter Maydell wrote: You may be hitting more issues because your target libc happens to be one that not very many other people are targetting. Is standard glibc not popular any more? Wow. Neither RHEL

Re: [Qemu-devel] [PATCH] pixman: remove -Wredundand-decls

2013-04-15 Thread Alexey Kardashevskiy
On 04/15/2013 09:14 PM, Peter Maydell wrote: On 15 April 2013 12:08, Alexey Kardashevskiy a...@ozlabs.ru wrote: On 04/15/2013 09:00 PM, Peter Maydell wrote: You may be hitting more issues because your target libc happens to be one that not very many other people are targetting. Is standard

Re: [Qemu-devel] [PATCH] pixman: remove -Wredundand-decls

2013-04-15 Thread Markus Armbruster
Alexey Kardashevskiy a...@ozlabs.ru writes: On 04/15/2013 08:01 PM, Peter Maydell wrote: On 15 April 2013 10:50, Alexey Kardashevskiy a...@ozlabs.ru wrote: /home/alexey/pcipassthru/qemu-impreza/../lib4qemu/usr/include/assert.h:67:13: error: redundant redeclaration of '__assert_fail'

Re: [Qemu-devel] [PATCH] pixman: remove -Wredundand-decls

2013-04-15 Thread Alexey Kardashevskiy
On 04/15/2013 10:57 PM, Markus Armbruster wrote: Alexey Kardashevskiy a...@ozlabs.ru writes: On 04/15/2013 08:01 PM, Peter Maydell wrote: On 15 April 2013 10:50, Alexey Kardashevskiy a...@ozlabs.ru wrote: /home/alexey/pcipassthru/qemu-impreza/../lib4qemu/usr/include/assert.h:67:13: error:

Re: [Qemu-devel] [PATCH] pixman: remove -Wredundand-decls

2013-04-15 Thread Markus Armbruster
Alexey Kardashevskiy a...@ozlabs.ru writes: On 04/15/2013 10:57 PM, Markus Armbruster wrote: Alexey Kardashevskiy a...@ozlabs.ru writes: On 04/15/2013 08:01 PM, Peter Maydell wrote: On 15 April 2013 10:50, Alexey Kardashevskiy a...@ozlabs.ru wrote:

Re: [Qemu-devel] [PATCH] pixman: remove -Wredundand-decls

2013-04-15 Thread Alexey Kardashevskiy
On 04/16/2013 01:55 AM, Markus Armbruster wrote: Alexey Kardashevskiy a...@ozlabs.ru writes: On 04/15/2013 10:57 PM, Markus Armbruster wrote: Alexey Kardashevskiy a...@ozlabs.ru writes: On 04/15/2013 08:01 PM, Peter Maydell wrote: On 15 April 2013 10:50, Alexey Kardashevskiy a...@ozlabs.ru

Re: [Qemu-devel] [PATCH] pixman: remove -Wredundand-decls

2013-04-15 Thread Alexey Kardashevskiy
On 04/16/2013 08:48 AM, Alexey Kardashevskiy wrote: On 04/16/2013 01:55 AM, Markus Armbruster wrote: Alexey Kardashevskiy a...@ozlabs.ru writes: On 04/15/2013 10:57 PM, Markus Armbruster wrote: Alexey Kardashevskiy a...@ozlabs.ru writes: On 04/15/2013 08:01 PM, Peter Maydell wrote: On 15

[Qemu-devel] [PATCH] pixman: remove -Wredundand-decls

2013-04-14 Thread Alexey Kardashevskiy
The assert.h header file from Fedora18 does not have #ifdef-#endif brackets around __assert function so it cannot compile with the -Wredundant-decls switch on. Some Linux distributions (such as Debian Wheezy) still do have those brackets arounb __assert functions (#ifndef _ASSERT_H_DECLS)