Re: [Qemu-devel] [PATCH] ppc/kvm: use kvm_vm_check_extension() in kvmppc_is_pr()

2017-09-14 Thread David Gibson
On Thu, Sep 14, 2017 at 12:48:04PM +0200, Greg Kurz wrote: > If the host has both KVM PR and KVM HV loaded and we pass: > > -machine pseries,accel=kvm,kvm-type=PR > > the kvmppc_is_pr() returns false instead of true. Since the helper > is mostly used as fallback, it doesn't have any real

Re: [Qemu-devel] [PATCH] ppc/kvm: use kvm_vm_check_extension() in kvmppc_is_pr()

2017-09-14 Thread Greg Kurz
On Thu, 14 Sep 2017 13:17:48 +0200 Thomas Huth wrote: > On 14.09.2017 12:48, Greg Kurz wrote: > > If the host has both KVM PR and KVM HV loaded and we pass: > > > > -machine pseries,accel=kvm,kvm-type=PR > > > > the kvmppc_is_pr() returns false instead of true. Since the

Re: [Qemu-devel] [PATCH] ppc/kvm: use kvm_vm_check_extension() in kvmppc_is_pr()

2017-09-14 Thread Thomas Huth
On 14.09.2017 12:48, Greg Kurz wrote: > If the host has both KVM PR and KVM HV loaded and we pass: > > -machine pseries,accel=kvm,kvm-type=PR > > the kvmppc_is_pr() returns false instead of true. Since the helper > is mostly used as fallback, it doesn't have any real impact with > recent

Re: [Qemu-devel] [PATCH] ppc/kvm: use kvm_vm_check_extension() in kvmppc_is_pr()

2017-09-14 Thread Thomas Huth
On 14.09.2017 12:48, Greg Kurz wrote: > If the host has both KVM PR and KVM HV loaded and we pass: > > -machine pseries,accel=kvm,kvm-type=PR > > the kvmppc_is_pr() returns false instead of true. Since the helper > is mostly used as fallback, it doesn't have any real impact with > recent

[Qemu-devel] [PATCH] ppc/kvm: use kvm_vm_check_extension() in kvmppc_is_pr()

2017-09-14 Thread Greg Kurz
If the host has both KVM PR and KVM HV loaded and we pass: -machine pseries,accel=kvm,kvm-type=PR the kvmppc_is_pr() returns false instead of true. Since the helper is mostly used as fallback, it doesn't have any real impact with recent kernels. A notable exception is the workaround to