[Qemu-devel] [PATCH] qemu-iotests: Fix _filter_qemu

2013-04-16 Thread Kevin Wolf
$QEMU_PROG happens to be 'qemu' in my setup, so this sed command replaces a bit too much. Restrict it to the start of the line and to when it's followed by a colon, i.e. the form used by error messages. Signed-off-by: Kevin Wolf kw...@redhat.com --- tests/qemu-iotests/common.filter | 2 +- 1

Re: [Qemu-devel] [PATCH] qemu-iotests: Fix _filter_qemu

2013-04-16 Thread Eric Blake
On 04/16/2013 03:48 AM, Kevin Wolf wrote: $QEMU_PROG happens to be 'qemu' in my setup, so this sed command replaces a bit too much. Restrict it to the start of the line and to when it's followed by a colon, i.e. the form used by error messages. Signed-off-by: Kevin Wolf kw...@redhat.com ---

Re: [Qemu-devel] [PATCH] qemu-iotests: Fix _filter_qemu

2013-04-16 Thread Stefan Hajnoczi
On Tue, Apr 16, 2013 at 06:26:38AM -0600, Eric Blake wrote: On 04/16/2013 03:48 AM, Kevin Wolf wrote: $QEMU_PROG happens to be 'qemu' in my setup, so this sed command replaces a bit too much. Restrict it to the start of the line and to when it's followed by a colon, i.e. the form used by

Re: [Qemu-devel] [PATCH] qemu-iotests: Fix _filter_qemu

2013-04-16 Thread Eric Blake
On 04/16/2013 07:16 AM, Stefan Hajnoczi wrote: +sed -e s#^$(basename $QEMU_PROG):#QEMU_PROG:#g Why spawn a basename process, when you can use shell to do the same? The problem with the POSIX shell string replacement is that the syntax is horrible. I can never remember what ${%}, ${%%},

Re: [Qemu-devel] [PATCH] qemu-iotests: Fix _filter_qemu

2013-04-16 Thread Markus Armbruster
Stefan Hajnoczi stefa...@redhat.com writes: [...] The problem with the POSIX shell string replacement is that the syntax is horrible. I can never remember what ${%}, ${%%}, ${#} and %{##} do. $(basename $QEMU_PROG) is clear (although it doesn't handle spaces in the filename!). Here's how I

Re: [Qemu-devel] [PATCH] qemu-iotests: Fix _filter_qemu

2013-04-16 Thread Kevin Wolf
Am 16.04.2013 um 15:16 hat Stefan Hajnoczi geschrieben: On Tue, Apr 16, 2013 at 06:26:38AM -0600, Eric Blake wrote: On 04/16/2013 03:48 AM, Kevin Wolf wrote: $QEMU_PROG happens to be 'qemu' in my setup, so this sed command replaces a bit too much. Restrict it to the start of the line and

Re: [Qemu-devel] [PATCH] qemu-iotests: Fix _filter_qemu

2013-04-16 Thread Stefan Hajnoczi
On Tue, Apr 16, 2013 at 03:52:14PM +0200, Markus Armbruster wrote: Stefan Hajnoczi stefa...@redhat.com writes: [...] The problem with the POSIX shell string replacement is that the syntax is horrible. I can never remember what ${%}, ${%%}, ${#} and %{##} do. $(basename $QEMU_PROG) is