Re: [Qemu-devel] [PATCH] qemu-timer: check active_timers outside lock/event

2016-12-01 Thread Stefan Hajnoczi
On Thu, Dec 01, 2016 at 10:03:43AM +0100, Paolo Bonzini wrote: > This avoids taking the active_timers_lock or resetting/setting the > timers_done_ev if there are no active timers. This removes a small > (2-3%) source of overhead for dataplane. The list is then checked > again inside the lock, or

[Qemu-devel] [PATCH] qemu-timer: check active_timers outside lock/event

2016-12-01 Thread Paolo Bonzini
This avoids taking the active_timers_lock or resetting/setting the timers_done_ev if there are no active timers. This removes a small (2-3%) source of overhead for dataplane. The list is then checked again inside the lock, or a NULL pointer could be dereferenced. Signed-off-by: Paolo Bonzini --