Re: [Qemu-devel] [PATCH] qmp-events: fix GUEST_PANICKED description formatting

2017-02-20 Thread Eric Blake
On 02/20/2017 12:12 PM, Denis V. Lunev wrote: >> But for 2.9, we only need to change the union. Eric, can you do that >> for us since my QAPI-fu is limited? >> >> Paolo >> > give me 5 minutes, I have patches for that, received them today. Yep, I've reviewed those patches. Thanks for the fast

Re: [Qemu-devel] [PATCH] qmp-events: fix GUEST_PANICKED description formatting

2017-02-20 Thread Denis V. Lunev
On 02/20/2017 07:10 PM, Paolo Bonzini wrote: > > On 16/02/2017 20:36, Eric Blake wrote: >> On that grounds, you already need the 'if (info)' for more than just the >> free, so this code motion is no longer quite as important. But now I'm >> noticing that it looks weird because you are freeing an

Re: [Qemu-devel] [PATCH] qmp-events: fix GUEST_PANICKED description formatting

2017-02-20 Thread Paolo Bonzini
On 16/02/2017 20:36, Eric Blake wrote: > On that grounds, you already need the 'if (info)' for more than just the > free, so this code motion is no longer quite as important. But now I'm > noticing that it looks weird because you are freeing an input parameter. > Generally, transfer semantics

[Qemu-devel] [PATCH] qmp-events: fix GUEST_PANICKED description formatting

2017-02-16 Thread Anton Nefedov
also remove a useless NULL check in the event reporting code Signed-off-by: Anton Nefedov --- qapi/event.json | 4 ++-- vl.c| 22 ++ 2 files changed, 12 insertions(+), 14 deletions(-) diff --git a/qapi/event.json b/qapi/event.json

Re: [Qemu-devel] [PATCH] qmp-events: fix GUEST_PANICKED description formatting

2017-02-16 Thread Eric Blake
On 02/16/2017 11:39 AM, Anton Nefedov wrote: > also remove a useless NULL check in the event reporting code > > Signed-off-by: Anton Nefedov > --- > qapi/event.json | 4 ++-- > vl.c| 22 ++ > 2 files changed, 12 insertions(+), 14

[Qemu-devel] [PATCH] qmp-events: fix GUEST_PANICKED description formatting

2017-02-16 Thread Anton Nefedov
Signed-off-by: Anton Nefedov --- qapi/event.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/qapi/event.json b/qapi/event.json index 970ff02..e02852c 100644 --- a/qapi/event.json +++ b/qapi/event.json @@ -488,9 +488,9 @@ # # @action:

Re: [Qemu-devel] [PATCH] qmp-events: fix GUEST_PANICKED description formatting

2017-02-16 Thread Eric Blake
On 02/16/2017 10:30 AM, Anton Nefedov wrote: > Signed-off-by: Anton Nefedov > --- > qapi/event.json | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/qapi/event.json b/qapi/event.json > index 970ff02..e02852c 100644 > --- a/qapi/event.json