Re: [Qemu-devel] [PATCH] qom: abort on error in property setter if caller passed errp == NULL

2013-12-02 Thread Peter Crosthwaite
On Fri, Nov 29, 2013 at 5:56 PM, Markus Armbruster arm...@redhat.com wrote: Peter Crosthwaite peter.crosthwa...@xilinx.com writes: On Fri, Nov 29, 2013 at 1:03 AM, Markus Armbruster arm...@redhat.com wrote: Paolo Bonzini pbonz...@redhat.com writes: Il 28/11/2013 14:23, Igor Mammedov ha

Re: [Qemu-devel] [PATCH] qom: abort on error in property setter if caller passed errp == NULL

2013-11-28 Thread Igor Mammedov
On Wed, 27 Nov 2013 21:58:18 -0700 Eric Blake ebl...@redhat.com wrote: On 11/27/2013 06:24 PM, Igor Mammedov wrote: in case if caller setting property doesn't care about error and passes in NULL as errp argument but error occurs in property setter, it is silently discarded leaving object

Re: [Qemu-devel] [PATCH] qom: abort on error in property setter if caller passed errp == NULL

2013-11-28 Thread Igor Mammedov
On Thu, 28 Nov 2013 15:10:50 +1000 Peter Crosthwaite peter.crosthwa...@xilinx.com wrote: Hi, On Thu, Nov 28, 2013 at 11:24 AM, Igor Mammedov imamm...@redhat.com wrote: in case if caller setting property doesn't care about error and passes in NULL as errp argument but error occurs in

Re: [Qemu-devel] [PATCH] qom: abort on error in property setter if caller passed errp == NULL

2013-11-28 Thread Paolo Bonzini
Il 28/11/2013 14:23, Igor Mammedov ha scritto: object_property_set(Foo, bar, baz, abort_on_err); that is just another way to put burden on caller, instead of doing it in one place. It's also much more self-documenting. The problem is that there is one very good case where you want the

Re: [Qemu-devel] [PATCH] qom: abort on error in property setter if caller passed errp == NULL

2013-11-28 Thread Andreas Färber
Am 28.11.2013 14:48, schrieb Igor Mammedov: On Thu, 28 Nov 2013 14:42:38 +0100 Andreas Färber afaer...@suse.de wrote: I will be more than happy to review and apply your patch (or contribute further ones) going through (mis)uses of error_is_set(). I've sent such one for target-i386/cpu.c see

Re: [Qemu-devel] [PATCH] qom: abort on error in property setter if caller passed errp == NULL

2013-11-28 Thread Markus Armbruster
Igor Mammedov imamm...@redhat.com writes: On Thu, 28 Nov 2013 15:10:50 +1000 Peter Crosthwaite peter.crosthwa...@xilinx.com wrote: Hi, On Thu, Nov 28, 2013 at 11:24 AM, Igor Mammedov imamm...@redhat.com wrote: in case if caller setting property doesn't care about error and passes in

Re: [Qemu-devel] [PATCH] qom: abort on error in property setter if caller passed errp == NULL

2013-11-28 Thread Markus Armbruster
Paolo Bonzini pbonz...@redhat.com writes: Il 28/11/2013 14:23, Igor Mammedov ha scritto: object_property_set(Foo, bar, baz, abort_on_err); that is just another way to put burden on caller, instead of doing it in one place. It's also much more self-documenting. The problem is that there

Re: [Qemu-devel] [PATCH] qom: abort on error in property setter if caller passed errp == NULL

2013-11-28 Thread Peter Crosthwaite
On Fri, Nov 29, 2013 at 1:03 AM, Markus Armbruster arm...@redhat.com wrote: Paolo Bonzini pbonz...@redhat.com writes: Il 28/11/2013 14:23, Igor Mammedov ha scritto: object_property_set(Foo, bar, baz, abort_on_err); that is just another way to put burden on caller, instead of doing it in

Re: [Qemu-devel] [PATCH] qom: abort on error in property setter if caller passed errp == NULL

2013-11-28 Thread Markus Armbruster
Peter Crosthwaite peter.crosthwa...@xilinx.com writes: On Fri, Nov 29, 2013 at 1:03 AM, Markus Armbruster arm...@redhat.com wrote: Paolo Bonzini pbonz...@redhat.com writes: Il 28/11/2013 14:23, Igor Mammedov ha scritto: object_property_set(Foo, bar, baz, abort_on_err); that is just

[Qemu-devel] [PATCH] qom: abort on error in property setter if caller passed errp == NULL

2013-11-27 Thread Igor Mammedov
in case if caller setting property doesn't care about error and passes in NULL as errp argument but error occurs in property setter, it is silently discarded leaving object in undefined state. As result it leads to hard to find bugs, so if caller doesn't care about error it must be sure that

Re: [Qemu-devel] [PATCH] qom: abort on error in property setter if caller passed errp == NULL

2013-11-27 Thread Eric Blake
On 11/27/2013 06:24 PM, Igor Mammedov wrote: in case if caller setting property doesn't care about error and passes in NULL as errp argument but error occurs in property setter, it is silently discarded leaving object in undefined state. As result it leads to hard to find bugs, so if caller

Re: [Qemu-devel] [PATCH] qom: abort on error in property setter if caller passed errp == NULL

2013-11-27 Thread Peter Crosthwaite
Hi, On Thu, Nov 28, 2013 at 11:24 AM, Igor Mammedov imamm...@redhat.com wrote: in case if caller setting property doesn't care about error and passes in NULL as errp argument but error occurs in property setter, it is silently discarded leaving object in undefined state. As result it leads

Re: [Qemu-devel] [PATCH] qom: abort on error in property setter if caller passed errp == NULL

2013-11-27 Thread Markus Armbruster
Peter Crosthwaite peter.crosthwa...@xilinx.com writes: Hi, On Thu, Nov 28, 2013 at 11:24 AM, Igor Mammedov imamm...@redhat.com wrote: in case if caller setting property doesn't care about error and passes in NULL as errp argument but error occurs in property setter, it is silently discarded