Re: [Qemu-devel] [PATCH] raspi: Add Raspberry Pi 1 support

On 8 April 2017 at 06:43, Omar Rizwan wrote: > Signed-off-by: Omar Rizwan > --- > hw/arm/Makefile.objs | 2 +- > hw/arm/bcm2835.c | 119 > +++ > hw/arm/bcm2835_peripherals.c | 1 + >

Re: [Qemu-devel] [PATCH] raspi: Add Raspberry Pi 1 support

On 04/12/2017 06:57 PM, no-re...@patchew.org wrote: > Hi, > > This series seems to have some coding style problems. See output below for > more information: > === OUTPUT BEGIN === > Checking PATCH 1/1: raspi: Add Raspberry Pi 1 support... > ERROR: line over 90 characters > #189: FILE:

Re: [Qemu-devel] [PATCH] raspi: Add Raspberry Pi 1 support

Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20170408054318.19830-1-omar.riz...@gmail.com Subject: [Qemu-devel] [PATCH] raspi: Add Raspberry Pi 1 support Type: series === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git

Re: [Qemu-devel] [PATCH] raspi: Add Raspberry Pi 1 support

> From: Andrew Baumann > Sent: Monday, 10 April 2017 10:05 > > From: Omar Rizwan [mailto:omar.riz...@gmail.com] > > Sent: Friday, 7 April 2017 23:13 > > I can't easily find documentation for that 0x4000 memory mapping, > > which I figured I'd keep in; should it just be removed from bcm2835? >

Re: [Qemu-devel] [PATCH] raspi: Add Raspberry Pi 1 support

> From: Omar Rizwan [mailto:omar.riz...@gmail.com] > Sent: Friday, 7 April 2017 23:13 > On Fri, Apr 7, 2017 at 10:57 PM Andrew Baumann > wrote: > > > From: Omar Rizwan [mailto:omar.riz...@gmail.com] > > > Sent: Friday, 7 April 2017 22:43 > > Did you do any testing

[Qemu-devel] [PATCH] raspi: Add Raspberry Pi 1 support

Signed-off-by: Omar Rizwan --- hw/arm/Makefile.objs | 2 +- hw/arm/bcm2835.c | 119 +++ hw/arm/bcm2835_peripherals.c | 1 + hw/arm/raspi.c | 47 ++--- include/hw/arm/bcm2835.h |

Re: [Qemu-devel] [PATCH] raspi: Add Raspberry Pi 1 support

Hi Andrew -- On Fri, Apr 7, 2017 at 10:57 PM Andrew Baumann wrote: > > Hi Omar, > > > From: Omar Rizwan [mailto:omar.riz...@gmail.com] > > Sent: Friday, 7 April 2017 22:43 > > Did you do any testing of this? One of the reasons I never got around to > upstreaming

Re: [Qemu-devel] [PATCH] raspi: Add Raspberry Pi 1 support

Hi Omar, > From: Omar Rizwan [mailto:omar.riz...@gmail.com] > Sent: Friday, 7 April 2017 22:43 Did you do any testing of this? One of the reasons I never got around to upstreaming this was that I couldn't get Raspbian working reliably (there was some problem with stalled DMA reads from the MMC