Re: [Qemu-devel] [PATCH] s390-ccw: Fix alignment for CCW1

2017-08-30 Thread Cornelia Huck
On Tue, 29 Aug 2017 14:45:51 -0400 Eric Farman wrote: > There were multiple $QEMUSRC directories on this system. At least one > 2.9.xx version didn't have commit 198c0d1f9df8c4 (and thus wouldn't care > about the boundary alignment), while others did. The

Re: [Qemu-devel] [PATCH] s390-ccw: Fix alignment for CCW1

2017-08-29 Thread Eric Farman
On 08/29/2017 08:45 AM, Cornelia Huck wrote: On Tue, 29 Aug 2017 08:39:27 -0400 Farhan Ali wrote: On 08/29/2017 08:04 AM, Cornelia Huck wrote: On Mon, 28 Aug 2017 10:28:53 -0400 Farhan Ali wrote: On 08/28/2017 10:19 AM, Halil Pasic

Re: [Qemu-devel] [PATCH] s390-ccw: Fix alignment for CCW1

2017-08-29 Thread Cornelia Huck
On Tue, 29 Aug 2017 08:39:27 -0400 Farhan Ali wrote: > On 08/29/2017 08:04 AM, Cornelia Huck wrote: > > On Mon, 28 Aug 2017 10:28:53 -0400 > > Farhan Ali wrote: > > > >> On 08/28/2017 10:19 AM, Halil Pasic wrote: > >>> > >>> > >>> On

Re: [Qemu-devel] [PATCH] s390-ccw: Fix alignment for CCW1

2017-08-29 Thread Farhan Ali
On 08/29/2017 08:04 AM, Cornelia Huck wrote: On Mon, 28 Aug 2017 10:28:53 -0400 Farhan Ali wrote: On 08/28/2017 10:19 AM, Halil Pasic wrote: On 08/28/2017 04:15 PM, Farhan Ali wrote: On 08/28/2017 10:05 AM, Cornelia Huck wrote: It's the alignment of the CCW

Re: [Qemu-devel] [PATCH] s390-ccw: Fix alignment for CCW1

2017-08-29 Thread Cornelia Huck
On Mon, 28 Aug 2017 10:28:53 -0400 Farhan Ali wrote: > On 08/28/2017 10:19 AM, Halil Pasic wrote: > > > > > > On 08/28/2017 04:15 PM, Farhan Ali wrote: > >> > >> > >> On 08/28/2017 10:05 AM, Cornelia Huck wrote: > >> It's the alignment of the CCW which causes

Re: [Qemu-devel] [PATCH] s390-ccw: Fix alignment for CCW1

2017-08-28 Thread Farhan Ali
Hi Phil, On 08/28/2017 11:04 AM, Philippe Mathieu-Daudé wrote: Can you provide the link script used in both systems? See on the previous thread:

Re: [Qemu-devel] [PATCH] s390-ccw: Fix alignment for CCW1

2017-08-28 Thread Philippe Mathieu-Daudé
Hi Farhan, On 08/28/2017 11:15 AM, Farhan Ali wrote: On 08/28/2017 10:05 AM, Cornelia Huck wrote: It's the alignment of the CCW which causes the problem. The exact error message when starting the guest was: ! No virtio device found ! Since it worked for SCSI and CDL, and failed for LDL

Re: [Qemu-devel] [PATCH] s390-ccw: Fix alignment for CCW1

2017-08-28 Thread Farhan Ali
On 08/28/2017 10:19 AM, Halil Pasic wrote: On 08/28/2017 04:15 PM, Farhan Ali wrote: On 08/28/2017 10:05 AM, Cornelia Huck wrote: It's the alignment of the CCW which causes the problem. The exact error message when starting the guest was: ! No virtio device found ! Since it worked for

Re: [Qemu-devel] [PATCH] s390-ccw: Fix alignment for CCW1

2017-08-28 Thread Halil Pasic
On 08/28/2017 04:15 PM, Farhan Ali wrote: > > > On 08/28/2017 10:05 AM, Cornelia Huck wrote: > It's the alignment of the CCW which causes the problem. > > The exact error message when starting the guest was: > > ! No virtio device found ! > > Since it worked for

Re: [Qemu-devel] [PATCH] s390-ccw: Fix alignment for CCW1

2017-08-28 Thread Farhan Ali
On 08/28/2017 10:05 AM, Cornelia Huck wrote: It's the alignment of the CCW which causes the problem. The exact error message when starting the guest was: ! No virtio device found ! Since it worked for SCSI and CDL, and failed for LDL disks on that particular system, we are not really sure

Re: [Qemu-devel] [PATCH] s390-ccw: Fix alignment for CCW1

2017-08-28 Thread Cornelia Huck
On Mon, 28 Aug 2017 09:52:08 -0400 Farhan Ali wrote: > On 08/28/2017 09:24 AM, Christian Borntraeger wrote: > > > > > > > > On 08/28/2017 03:18 PM, Farhan Ali wrote: > >> > >> > >> On 08/28/2017 09:06 AM, Cornelia Huck wrote: > >>> On Mon, 28 Aug 2017 08:56:42 -0400

Re: [Qemu-devel] [PATCH] s390-ccw: Fix alignment for CCW1

2017-08-28 Thread Farhan Ali
On 08/28/2017 09:24 AM, Christian Borntraeger wrote: On 08/28/2017 03:18 PM, Farhan Ali wrote: On 08/28/2017 09:06 AM, Cornelia Huck wrote: On Mon, 28 Aug 2017 08:56:42 -0400 Farhan Ali wrote: On 08/28/2017 04:22 AM, Cornelia Huck wrote: On Fri, 25 Aug 2017

Re: [Qemu-devel] [PATCH] s390-ccw: Fix alignment for CCW1

2017-08-28 Thread Christian Borntraeger
On 08/28/2017 03:18 PM, Farhan Ali wrote: > > > On 08/28/2017 09:06 AM, Cornelia Huck wrote: >> On Mon, 28 Aug 2017 08:56:42 -0400 >> Farhan Ali wrote: >> >>> On 08/28/2017 04:22 AM, Cornelia Huck wrote: On Fri, 25 Aug 2017 11:05:30 -0400 Farhan Ali

Re: [Qemu-devel] [PATCH] s390-ccw: Fix alignment for CCW1

2017-08-28 Thread Farhan Ali
On 08/28/2017 09:06 AM, Cornelia Huck wrote: On Mon, 28 Aug 2017 08:56:42 -0400 Farhan Ali wrote: On 08/28/2017 04:22 AM, Cornelia Huck wrote: On Fri, 25 Aug 2017 11:05:30 -0400 Farhan Ali wrote: On 08/25/2017 10:04 AM, Cornelia Huck

Re: [Qemu-devel] [PATCH] s390-ccw: Fix alignment for CCW1

2017-08-28 Thread Cornelia Huck
On Mon, 28 Aug 2017 08:56:42 -0400 Farhan Ali wrote: > On 08/28/2017 04:22 AM, Cornelia Huck wrote: > > On Fri, 25 Aug 2017 11:05:30 -0400 > > Farhan Ali wrote: > > > >> On 08/25/2017 10:04 AM, Cornelia Huck wrote: > >>> On Fri, 25 Aug

Re: [Qemu-devel] [PATCH] s390-ccw: Fix alignment for CCW1

2017-08-28 Thread Farhan Ali
On 08/28/2017 04:22 AM, Cornelia Huck wrote: On Fri, 25 Aug 2017 11:05:30 -0400 Farhan Ali wrote: On 08/25/2017 10:04 AM, Cornelia Huck wrote: On Fri, 25 Aug 2017 09:24:46 -0400 Farhan Ali wrote: The commit 198c0d1f9df8c4 s390x/css:

Re: [Qemu-devel] [PATCH] s390-ccw: Fix alignment for CCW1

2017-08-28 Thread Cornelia Huck
On Fri, 25 Aug 2017 11:05:30 -0400 Farhan Ali wrote: > On 08/25/2017 10:04 AM, Cornelia Huck wrote: > > On Fri, 25 Aug 2017 09:24:46 -0400 > > Farhan Ali wrote: > > > >> The commit 198c0d1f9df8c4 s390x/css: check ccw address validity > >>

Re: [Qemu-devel] [PATCH] s390-ccw: Fix alignment for CCW1

2017-08-25 Thread Farhan Ali
On 08/25/2017 10:04 AM, Cornelia Huck wrote: On Fri, 25 Aug 2017 09:24:46 -0400 Farhan Ali wrote: The commit 198c0d1f9df8c4 s390x/css: check ccw address validity exposes an alignment issue in ccw bios. According to PoP the CCW must be doubleword aligned. Let's fix

Re: [Qemu-devel] [PATCH] s390-ccw: Fix alignment for CCW1

2017-08-25 Thread Cornelia Huck
On Fri, 25 Aug 2017 09:24:46 -0400 Farhan Ali wrote: > The commit 198c0d1f9df8c4 s390x/css: check ccw address validity > exposes an alignment issue in ccw bios. > > According to PoP the CCW must be doubleword aligned. Let's fix > this in the bios. > > Cc:

Re: [Qemu-devel] [PATCH] s390-ccw: Fix alignment for CCW1

2017-08-25 Thread no-reply
-devel] [PATCH] s390-ccw: Fix alignment for CCW1 === TEST SCRIPT BEGIN === #!/bin/bash set -e git submodule update --init dtc # Let docker tests dump environment info export SHOW_ENV=1 export J=8 time make docker-test-quick@centos6 time make docker-test-build@min-glib time make docker-test-mingw@fedora

[Qemu-devel] [PATCH] s390-ccw: Fix alignment for CCW1

2017-08-25 Thread Farhan Ali
The commit 198c0d1f9df8c4 s390x/css: check ccw address validity exposes an alignment issue in ccw bios. According to PoP the CCW must be doubleword aligned. Let's fix this in the bios. Cc: qemu-sta...@nongnu.org Signed-off-by: Farhan Ali Reviewed-by: Halil Pasic