Re: [Qemu-devel] [PATCH] sheepdog: Remove unnecessary NULL check in sd_prealloc()

2018-05-22 Thread Kevin Wolf
Am 18.05.2018 um 20:17 hat Peter Maydell geschrieben: > In commit 8b9ad56e9cbfd852a, we removed the code that could result > in our getting to sd_prealloc()'s out_with_err_set label with a > NULL blk pointer. That makes the NULL check in the error-handling > path unnecessary, and Coverity gripes

[Qemu-devel] [PATCH] sheepdog: Remove unnecessary NULL check in sd_prealloc()

2018-05-18 Thread Peter Maydell
In commit 8b9ad56e9cbfd852a, we removed the code that could result in our getting to sd_prealloc()'s out_with_err_set label with a NULL blk pointer. That makes the NULL check in the error-handling path unnecessary, and Coverity gripes about it (CID 1390636). Delete the redundant check.