Re: [Qemu-devel] [PATCH] slirp: don't zero ti_i since we access it later.

Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH] slirp: don't zero ti_i since we access it later. Type: series Message-id: 20171108225340.10194-1-lep...@google.com === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1

Re: [Qemu-devel] [PATCH] slirp: don't zero ti_i since we access it later.

Tao Wu(吴涛@Eng), on jeu. 09 nov. 2017 10:48:27 -0800, wrote: > Thanks. Actually this is a follow up with my previous effort to fix this bug. > I was busy on something else and then got lost in that old thread. Now I just > checked some my local patch > to see if they've merged to upstream and then

Re: [Qemu-devel] [PATCH] slirp: don't zero ti_i since we access it later.

Thanks. Actually this is a follow up with my previous effort to fix this bug. I was busy on something else and then got lost in that old thread. Now I just checked some my local patch to see if they've merged to upstream and then found it out. This is old thread about this:

Re: [Qemu-devel] [PATCH] slirp: don't zero ti_i since we access it later.

Hello, Tao Wu, on mer. 08 nov. 2017 14:53:40 -0800, wrote: > The current code looks buggy, we zero ti_i while we access > ti_dst/ti_src later. Mmm, indeed, looking again at how it was introduced, it was too much. Samuel

Re: [Qemu-devel] [PATCH] slirp: don't zero ti_i since we access it later.

Hi Adding Guillaume in CC, who wrote that line in commit 98c63057d2144 On Wed, Nov 8, 2017 at 11:53 PM, Tao Wu via Qemu-devel wrote: > The current code looks buggy, we zero ti_i while we access > ti_dst/ti_src later. Could you described the symptoms and why you fixed it

[Qemu-devel] [PATCH] slirp: don't zero ti_i since we access it later.

The current code looks buggy, we zero ti_i while we access ti_dst/ti_src later. Signed-off-by: Tao Wu --- slirp/tcp_subr.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/slirp/tcp_subr.c b/slirp/tcp_subr.c index dc8b4bbb50..da0d53743f 100644