[Qemu-devel] [PATCH] spice: flip streaming video mode to off by default

2013-12-02 Thread Gerd Hoffmann 
Video streaming detection heuristics in spice-server have problems
keeping modern desktop animations (as done by gnome shell) and real
video playback apart.  This leads to jpeg compression artefacts on
your desktop, due to spice using mjpeg to send what it thinks is
a video stream.

Turn off video detection by default to avoid these artifacts.

Signed-off-by: Gerd Hoffmann kra...@redhat.com
---
 ui/spice-core.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/ui/spice-core.c b/ui/spice-core.c
index e4d533d..9fb9544 100644
--- a/ui/spice-core.c
+++ b/ui/spice-core.c
@@ -776,6 +776,8 @@ void qemu_spice_init(void)
 if (str) {
 int streaming_video = parse_stream_video(str);
 spice_server_set_streaming_video(spice_server, streaming_video);
+} else {
+spice_server_set_streaming_video(spice_server, SPICE_STREAM_VIDEO_OFF);
 }
 
 spice_server_set_agent_mouse
-- 
1.8.3.1

Re: [Qemu-devel] [PATCH] spice: flip streaming video mode to off by default

2013-12-02 Thread Alon Levy 
On 12/02/2013 12:27 PM, Gerd Hoffmann wrote:
 Video streaming detection heuristics in spice-server have problems
 keeping modern desktop animations (as done by gnome shell) and real
 video playback apart.  This leads to jpeg compression artefacts on
 your desktop, due to spice using mjpeg to send what it thinks is
 a video stream.
 
 Turn off video detection by default to avoid these artifacts.
 


Reviewed-by: Alon Levy al...@redhat.com

 Signed-off-by: Gerd Hoffmann kra...@redhat.com
 ---
  ui/spice-core.c | 2 ++
  1 file changed, 2 insertions(+)
 
 diff --git a/ui/spice-core.c b/ui/spice-core.c
 index e4d533d..9fb9544 100644
 --- a/ui/spice-core.c
 +++ b/ui/spice-core.c
 @@ -776,6 +776,8 @@ void qemu_spice_init(void)
  if (str) {
  int streaming_video = parse_stream_video(str);
  spice_server_set_streaming_video(spice_server, streaming_video);
 +} else {
 +spice_server_set_streaming_video(spice_server, 
 SPICE_STREAM_VIDEO_OFF);
  }
  
  spice_server_set_agent_mouse