Re: [Qemu-devel] [PATCH] target-i386: Mask NX bit from cpu_get_phys_page_debug result

2012-03-06 Thread Avi Kivity
On 03/06/2012 02:56 PM, Avi Kivity wrote: > > diff --git a/target-i386/helper.c b/target-i386/helper.c > > index af6bba2..40fe407 100644 > > --- a/target-i386/helper.c > > +++ b/target-i386/helper.c > > @@ -947,7 +947,7 @@ target_phys_addr_t cpu_get_phys_page_debug(CPUState > > *env, target_ulong

Re: [Qemu-devel] [PATCH] target-i386: Mask NX bit from cpu_get_phys_page_debug result

2012-03-06 Thread Avi Kivity
On 03/06/2012 02:23 PM, Jan Kiszka wrote: > This was a long pending bug, now revealed by the assert in > phys_page_find that stumbled over the large page index returned by > cpu_get_phys_page_debug for NX-marked pages. > > Signed-off-by: Jan Kiszka > --- > > Was easily triggerable by attaching gdb

[Qemu-devel] [PATCH] target-i386: Mask NX bit from cpu_get_phys_page_debug result

2012-03-06 Thread Jan Kiszka
This was a long pending bug, now revealed by the assert in phys_page_find that stumbled over the large page index returned by cpu_get_phys_page_debug for NX-marked pages. Signed-off-by: Jan Kiszka --- Was easily triggerable by attaching gdb to the guest and doing some backtraces that reached int