On 09/12/2017 02:04 PM, Paolo Bonzini wrote:
> I wonder if QEMU_BUILD_BUG_ON (at least in atomics) should not use a
> static assertion, but rather the 'error ("MESSAGE")' attribute instead.
> This way, if the code is dead it does not cause a build failure.
I think that would be an excellent idea.
On 11/09/2017 23:37, Peter Maydell wrote:
> On 11 September 2017 at 21:49, Philippe Mathieu-Daudé wrote:
>> this fixes building for ppc64 on ppc32 (changed in 5964fca8a12c):
>>
>> qemu/tcg/ppc/tcg-target.inc.c: In function 'tb_target_set_jmp_target':
>>
On 09/12/2017 02:01 PM, Richard Henderson wrote:
On 09/11/2017 01:49 PM, Philippe Mathieu-Daudé wrote:
-atomic_set((uint64_t *)jmp_addr, pair);
+atomic_set__nocheck((uint64_t *)jmp_addr, pair);
flush_icache_range(jmp_addr, jmp_addr + 8);
} else {
On 09/11/2017 01:49 PM, Philippe Mathieu-Daudé wrote:
> -atomic_set((uint64_t *)jmp_addr, pair);
> +atomic_set__nocheck((uint64_t *)jmp_addr, pair);
> flush_icache_range(jmp_addr, jmp_addr + 8);
> } else {
> intptr_t diff = addr - jmp_addr;
>
Queued,
On 12 September 2017 at 05:23, Richard Henderson wrote:
> On 09/11/2017 02:37 PM, Peter Maydell wrote:
>> On 11 September 2017 at 21:49, Philippe Mathieu-Daudé
>> wrote:
>>> this fixes building for ppc64 on ppc32 (changed in 5964fca8a12c):
>>>
>>>
On 09/11/2017 02:37 PM, Peter Maydell wrote:
> On 11 September 2017 at 21:49, Philippe Mathieu-Daudé wrote:
>> this fixes building for ppc64 on ppc32 (changed in 5964fca8a12c):
>>
>> qemu/tcg/ppc/tcg-target.inc.c: In function 'tb_target_set_jmp_target':
>>
On 09/11/2017 01:49 PM, Philippe Mathieu-Daudé wrote:
> this fixes building for ppc64 on ppc32 (changed in 5964fca8a12c):
>
> qemu/tcg/ppc/tcg-target.inc.c: In function 'tb_target_set_jmp_target':
> qemu/include/qemu/compiler.h:86:30: error: static assertion failed: "not
> expecting:
On 11 September 2017 at 21:49, Philippe Mathieu-Daudé wrote:
> this fixes building for ppc64 on ppc32 (changed in 5964fca8a12c):
>
> qemu/tcg/ppc/tcg-target.inc.c: In function 'tb_target_set_jmp_target':
> qemu/include/qemu/compiler.h:86:30: error: static assertion failed:
this fixes building for ppc64 on ppc32 (changed in 5964fca8a12c):
qemu/tcg/ppc/tcg-target.inc.c: In function 'tb_target_set_jmp_target':
qemu/include/qemu/compiler.h:86:30: error: static assertion failed: "not
expecting: sizeof(*(uint64_t *)jmp_addr) > ATOMIC_REG_SIZE"