Re: [Qemu-devel] [PATCH] tcg/ppc: disable atomic write check on ppc32

2017-09-13 Thread Richard Henderson
On 09/12/2017 02:04 PM, Paolo Bonzini wrote: > I wonder if QEMU_BUILD_BUG_ON (at least in atomics) should not use a > static assertion, but rather the 'error ("MESSAGE")' attribute instead. > This way, if the code is dead it does not cause a build failure. I think that would be an excellent idea.

Re: [Qemu-devel] [PATCH] tcg/ppc: disable atomic write check on ppc32

2017-09-12 Thread Paolo Bonzini
On 11/09/2017 23:37, Peter Maydell wrote: > On 11 September 2017 at 21:49, Philippe Mathieu-Daudé wrote: >> this fixes building for ppc64 on ppc32 (changed in 5964fca8a12c): >> >> qemu/tcg/ppc/tcg-target.inc.c: In function 'tb_target_set_jmp_target': >>

Re: [Qemu-devel] [PATCH] tcg/ppc: disable atomic write check on ppc32

2017-09-12 Thread Philippe Mathieu-Daudé
On 09/12/2017 02:01 PM, Richard Henderson wrote: On 09/11/2017 01:49 PM, Philippe Mathieu-Daudé wrote: -atomic_set((uint64_t *)jmp_addr, pair); +atomic_set__nocheck((uint64_t *)jmp_addr, pair); flush_icache_range(jmp_addr, jmp_addr + 8); } else {

Re: [Qemu-devel] [PATCH] tcg/ppc: disable atomic write check on ppc32

2017-09-12 Thread Richard Henderson
On 09/11/2017 01:49 PM, Philippe Mathieu-Daudé wrote: > -atomic_set((uint64_t *)jmp_addr, pair); > +atomic_set__nocheck((uint64_t *)jmp_addr, pair); > flush_icache_range(jmp_addr, jmp_addr + 8); > } else { > intptr_t diff = addr - jmp_addr; > Queued,

Re: [Qemu-devel] [PATCH] tcg/ppc: disable atomic write check on ppc32

2017-09-12 Thread Peter Maydell
On 12 September 2017 at 05:23, Richard Henderson wrote: > On 09/11/2017 02:37 PM, Peter Maydell wrote: >> On 11 September 2017 at 21:49, Philippe Mathieu-Daudé >> wrote: >>> this fixes building for ppc64 on ppc32 (changed in 5964fca8a12c): >>> >>>

Re: [Qemu-devel] [PATCH] tcg/ppc: disable atomic write check on ppc32

2017-09-11 Thread Richard Henderson
On 09/11/2017 02:37 PM, Peter Maydell wrote: > On 11 September 2017 at 21:49, Philippe Mathieu-Daudé wrote: >> this fixes building for ppc64 on ppc32 (changed in 5964fca8a12c): >> >> qemu/tcg/ppc/tcg-target.inc.c: In function 'tb_target_set_jmp_target': >>

Re: [Qemu-devel] [PATCH] tcg/ppc: disable atomic write check on ppc32

2017-09-11 Thread Richard Henderson
On 09/11/2017 01:49 PM, Philippe Mathieu-Daudé wrote: > this fixes building for ppc64 on ppc32 (changed in 5964fca8a12c): > > qemu/tcg/ppc/tcg-target.inc.c: In function 'tb_target_set_jmp_target': > qemu/include/qemu/compiler.h:86:30: error: static assertion failed: "not > expecting:

Re: [Qemu-devel] [PATCH] tcg/ppc: disable atomic write check on ppc32

2017-09-11 Thread Peter Maydell
On 11 September 2017 at 21:49, Philippe Mathieu-Daudé wrote: > this fixes building for ppc64 on ppc32 (changed in 5964fca8a12c): > > qemu/tcg/ppc/tcg-target.inc.c: In function 'tb_target_set_jmp_target': > qemu/include/qemu/compiler.h:86:30: error: static assertion failed:

[Qemu-devel] [PATCH] tcg/ppc: disable atomic write check on ppc32

2017-09-11 Thread Philippe Mathieu-Daudé
this fixes building for ppc64 on ppc32 (changed in 5964fca8a12c): qemu/tcg/ppc/tcg-target.inc.c: In function 'tb_target_set_jmp_target': qemu/include/qemu/compiler.h:86:30: error: static assertion failed: "not expecting: sizeof(*(uint64_t *)jmp_addr) > ATOMIC_REG_SIZE"