Re: [Qemu-devel] [PATCH] tcg: correct 32-bit tcg_gen_ld8s_i64 sign-extension

2016-10-28 Thread Richard Henderson
On 10/28/2016 05:42 AM, Peter Maydell wrote: On 28 October 2016 at 00:35, Joseph Myers wrote: The version of tcg_gen_ld8s_i64 for 32-bit systems does a load into the low part of the return value - then attempts a sign extension into the high part, but wrongly sets the

Re: [Qemu-devel] [PATCH] tcg: correct 32-bit tcg_gen_ld8s_i64 sign-extension

2016-10-28 Thread Peter Maydell
On 28 October 2016 at 00:35, Joseph Myers wrote: > The version of tcg_gen_ld8s_i64 for 32-bit systems does a load into > the low part of the return value - then attempts a sign extension into > the high part, but wrongly sets the high part to a sign extension of > itself

[Qemu-devel] [PATCH] tcg: correct 32-bit tcg_gen_ld8s_i64 sign-extension

2016-10-27 Thread Joseph Myers
The version of tcg_gen_ld8s_i64 for 32-bit systems does a load into the low part of the return value - then attempts a sign extension into the high part, but wrongly sets the high part to a sign extension of itself rather than of the low part. This results in TCG internal errors from the use of