Re: [Qemu-devel] [PATCH] tpm: Zero-init structure to avoid uninitialized variables in valgrind log

2018-10-24 Thread Philippe Mathieu-Daudé 

On 24/10/18 21:14, Stefan Berger wrote:

Zero-init the ptm_loc structure so that we don't have fields that
are not initialised.

Signed-off-by: Stefan Berger 


Reviewed-by: Philippe Mathieu-Daudé 


---
  hw/tpm/tpm_emulator.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/tpm/tpm_emulator.c b/hw/tpm/tpm_emulator.c
index 10bc20dbec..968f06ae3b 100644
--- a/hw/tpm/tpm_emulator.c
+++ b/hw/tpm/tpm_emulator.c
@@ -158,7 +158,7 @@ static int tpm_emulator_unix_tx_bufs(TPMEmulator *tpm_emu,
  static int tpm_emulator_set_locality(TPMEmulator *tpm_emu, uint8_t 
locty_number,
   Error **errp)
  {
-ptm_loc loc;
+ptm_loc loc = { 0 };
  
  if (tpm_emu->cur_locty_number == locty_number) {

  return 0;

[Qemu-devel] [PATCH] tpm: Zero-init structure to avoid uninitialized variables in valgrind log

2018-10-24 Thread Stefan Berger 
Zero-init the ptm_loc structure so that we don't have fields that
are not initialised.

Signed-off-by: Stefan Berger 
---
 hw/tpm/tpm_emulator.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/tpm/tpm_emulator.c b/hw/tpm/tpm_emulator.c
index 10bc20dbec..968f06ae3b 100644
--- a/hw/tpm/tpm_emulator.c
+++ b/hw/tpm/tpm_emulator.c
@@ -158,7 +158,7 @@ static int tpm_emulator_unix_tx_bufs(TPMEmulator *tpm_emu,
 static int tpm_emulator_set_locality(TPMEmulator *tpm_emu, uint8_t 
locty_number,
  Error **errp)
 {
-ptm_loc loc;
+ptm_loc loc = { 0 };
 
 if (tpm_emu->cur_locty_number == locty_number) {
 return 0;
-- 
2.17.1